-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HAC models #14
Comments
Hi Michel, Regarding the MarginPolish error: @tpesout can help you with it. HAC model: All models are trained on HAC base-called data. We are trying to assess if the fast prediction model, and it's applicability. And the model: we are trying to assess and provide a model for the latest guppy version, but the summer hiatus and the expense of base-calling are holding us back. As we re-group after summer and get the new base called data, we will publish updated models. For now, guppy 2.3.3 would be the one to use for 3.0.2 as the RLE confusion matrix matches closely. |
I was able to replicate the model error you were getting, can you delete the local copy of your guppy 235 file and do this: This downloads the raw json file and makes sure you don't download html content. |
Great, thanks for fixing this. Works fine now! I also have some datasets from different basecalling models (from older and newer firmware). Not sure yet how to apply HELEN to such cases. Do you have any suggestions? |
@MichelMoser, we describe why we need different models for different versions of basecallers: If you look at figure 18 on page 41 you'll see that the confusion matrix for two basecallers is different. I think the 3.0.5 is the closest to 2.3.3 so you would get the best results for 3.0.5 with 2.3.3. Do you have training data (HG002) for these basecaller versions? if yes then you can train models for each version and use that. |
@kishwarshafin, yes, i totally understand why different models are needed to match the different guppy basecall-models. I wonder how i could get optimal polishing results with mP+H for genomes assembled from a combination of different nanopore reads (guppy233-called and guppy235-called). We work with non-model organisms (fishes) without reference genomes, so training is difficult to do. |
I see. Sorry, I misinterpreted your question. Ok, in such case you also need to consider that different basecallers report different base qualities and the model rely highly on the reported qualities from the basecaller. It is extremely important that you pick the right model for the right basecaller. I would suggest that you gather all your data and basecall with a single guppy basecaller i.e. 3.0.5 then when we release a 3.0.5 or higher basecaller model you use that. Mixing 233 and 235 will make the model perform badly. It's a bit frustrating to keep up with all the frequent upgrades of basecaller but that's the best we can do now. |
I can confidently say that I was wrong about my statement last month. I ran a simple test by mixing reads from 235 and 233 and performed polishing and it looked fine. So, you can mix your reads and do the polishing to get better results. Sorry for being so late on this. |
Thats great news. Thanks for the follow-up. |
Yes, the data was 233 + 235 mixture and model was 235. Also, if you want to wait, we are working on a 305 model, should be able to deliver in a week or so. Thanks for your patience. |
Great, cant wait for this! |
The marginPolish model is updated to the master and here's the HELEN model for 305: There are still a few tests that we need to do before making it public but the initial tests look very good. :-) Good luck! |
Great! Already started a run to see how it compares to previous models. BUSCO will tell =) |
Great! Please share the results if you can. |
Hi, I did a comparison of newest models for HELEN guppy305) and marginPolish with the previous one (guppy235) and medaka (r941_prom_high) Unfortunately, the guppy305 model did not perform well on our data. Here the overview:
marginPolish tpesout/margin_polish:latest |
Hi @MichelMoser , I have a few questions for you:
From our findings, we saw that BUSCO is not a great metric for assembly accuracy. But this big of a difference is concerning. |
Hi, I was surprised by the result as well.
What kind metric do you prefer to assess assembly accuracy? Comparison to Illumina contigs?
Let me know what you think. email: michel.moser at nmbu.no |
I'll follow up with you over the email and close this issue here as it's non-related to the pipeline. |
Dear HELEN developers,
When running MarginPolish with the allParams.np.human.guppy-ff-235.json model, i get a Calloc error.
The program runs if using another model:
Is the 235 model file corrupted?
Also, i saw your latest models for polishing is named guppy 2.3.5.
Is this trained on the HAC configuration files?
We are currently using promethION data basecalled with HAC models on guppy 3.0.5 provided by ONT and i wonder which model would fit the data best.
model files used for basecalling:
Maybe it would be more accurate to name models after their used basecall models instead of guppy versions?
Thanks,
michel
The text was updated successfully, but these errors were encountered: