Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #139: Add example of excluding a call to a vendored dependency #173

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Fix #139: Add example of excluding a call to a vendored dependency #173

merged 1 commit into from
Jun 19, 2020

Conversation

jdkaplan
Copy link
Contributor

I also ran into the issue in #139, and @alexflint's comment resolved it for me. This adds an example to the readme to help other people out of this situation.

This worked for me, but I don't know anything about how errcheck actually matches the names. In case it matters, I'm using dep for dependency management, and my layout is exactly as my change describes.

@jdkaplan
Copy link
Contributor Author

CI is failing for an unrelated reason, but it looks like #168 will fix it.

@kisielk kisielk merged commit 28a963f into kisielk:master Jun 19, 2020
@jdkaplan jdkaplan deleted the issue/139 branch June 19, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants