Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiss: check if directory exists during update #19

Closed
kyx0r opened this issue Feb 25, 2021 · 2 comments
Closed

kiss: check if directory exists during update #19

kyx0r opened this issue Feb 25, 2021 · 2 comments

Comments

@kyx0r
Copy link

kyx0r commented Feb 25, 2021

Hello @git-bruh and @dilyn-corner I've got a rather philosophical issue here.

But first, i'd like to point out that on github the kiss package manager repository does not have a issues page like this repo-main
repository which is why I am writing it here. And yes I am too lazy to go onto IRC, so deal with it.

I have some repos paths being set to appended to KISS_PATH here.
https://github.com/kyx0r/klec/blob/685c860892ae81c3e009576ce36bb8c633d2e9b5/dotfiles/.profile#L6

As you can see, I am forced to check for every directory because if I don't when I run kiss update I get error message like this one:
/usr/bin/kiss: cd: line 1307: can't cd to /root/kiss/gcommunity/community: No such file or directory

The problem is that I use my configs on many different machines and not every machine has the same repos and requirements. And this error is not handled by the package manager which causes the update to fail. The problem can be solved by simply adding a check inside kiss on the return error code of the cd command.

I hope it's not too big of an ask to add a check + continue in kiss so that I don't have to keep adding the monstrocity of if statements in my .profile . I might as well be beneficial to you also. But again you have to sacrifice 2 lines of code for that, which may or may not surpass the said minimalism standard.

@dilyn-corner
Copy link
Member

I can take a peak at having kiss not exit when it fails to update any given repository in KISS_PATH, and find a nonintrusive way of notifying users their repositories aren't where they might think they are.

Thanks for letting me know that issues can't be opened at the package manager repo; I've enabled them there and for init.

@dilyn-corner
Copy link
Member

Resolved & released in kiss-community/kiss@152bb47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants