Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom fonts should be loaded from it's own scss file #279

Closed
ichim-david opened this issue Nov 29, 2023 · 1 comment
Closed

Custom fonts should be loaded from it's own scss file #279

ichim-david opened this issue Nov 29, 2023 · 1 comment
Assignees
@ichim-david
Labels
bug Something isn't working

Comments

@ichim-david
Copy link
Collaborator

If you want to use another set of fonts in another project typography and typo-custom forces you to load Iter and Metropolis whether you want to or not.
@ichim-david ichim-david added the bug Something isn't working label Nov 29, 2023
@ichim-david ichim-david self-assigned this Nov 29, 2023
@ichim-david
Copy link
Collaborator Author

Added #280 pull request for fixing this hardcode.

@sneridagh A potential next step could be to avoid manually adding the fonts and instead use
https://fontsource.org/fonts/inter/install
https://fontsource.org/fonts/metropolis/install
It would be great to not have to bundle a font at all and instead use npm package this way you can really
say that if you want other fonts for cms or page you add your font dependencies and you reference in the
variables.

sneridagh added a commit that referenced this issue Dec 15, 2023
@sneridagh
Merge branch 'main' into adaptnewslider6.0.0-alpha.0-inlighttheme
7b143f6 
* main:
  Un-pin eslint-plugin-jsx-a11y version (#299)
  Release 2.1.0
  Update contentMetadataTagsImageField settings to use preview_image field(#274) (#284)
  Add Brazilian Portuguese translation (#295)
  Fixes #279 load custom fonts from a separate file and allow setting of cms font instead of hardcoding to Metropolis  (#280)
  Fix Image View forces in image content type (#292)
  Also clean up Navigation PropTypes (#285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ichim-david ichim-david

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ichim-david