Fixes #279 load custom fonts from a separate file and allow setting of cms font instead of hardcoding to Metropolis #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenri
approved these changes
Nov 30, 2023
sneridagh
approved these changes
Dec 1, 2023
sneridagh
requested changes
Dec 1, 2023
sneridagh
added a commit
that referenced
this pull request
Dec 15, 2023
* main: Un-pin eslint-plugin-jsx-a11y version (#299) Release 2.1.0 Update contentMetadataTagsImageField settings to use preview_image field(#274) (#284) Add Brazilian Portuguese translation (#295) Fixes #279 load custom fonts from a separate file and allow setting of cms font instead of hardcoding to Metropolis (#280) Fix Image View forces in image content type (#292) Also clean up Navigation PropTypes (#285)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our project needs to load other custom font faces, the only way todo and still get typography rules is to move the font loading to another file which we can avoid loading in our theme.scss