Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Image View forces in image content type #292

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Fix Image View forces in image content type #292

merged 3 commits into from
Dec 12, 2023

Conversation

iRohitSingh
Copy link
Member

No description provided.

@iRohitSingh iRohitSingh added the bug Something isn't working label Dec 12, 2023
@iRohitSingh
Copy link
Member Author

Fix #293

news/293.bugfix Outdated Show resolved Hide resolved
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @sneridagh @steffenri This is what we always intended for the image view, right?

@steffenri
Copy link
Member

@davisagli Yes. Only took us like half a year to fix it :D

@davisagli davisagli merged commit 731dafa into main Dec 12, 2023
7 checks passed
@davisagli davisagli deleted the image-view branch December 12, 2023 16:44
sneridagh added a commit that referenced this pull request Dec 15, 2023
* main:
  Un-pin eslint-plugin-jsx-a11y version (#299)
  Release 2.1.0
  Update contentMetadataTagsImageField settings to use preview_image field(#274) (#284)
  Add Brazilian Portuguese translation (#295)
  Fixes #279 load custom fonts from a separate file and allow setting of cms font instead of hardcoding to Metropolis  (#280)
  Fix Image View forces in image content type (#292)
  Also clean up Navigation PropTypes (#285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants