Fix update thumbnails-overlay after paginating #5276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-stoehr
suggested changes
Aug 4, 2022
There was a problem hiding this comment.
It would be better to only update the components that actually change, instead of updating the whole form. You should only update @(.thumbnail-overlay) to update the labels in the overlay with the new pagination.
This is currently not possible with the overlay being rendered by h:panelGroup elements. Bu you could use p:outputPanel instead.
IkramMaalej
force-pushed
the
thumbnails-overlay
branch
from
c6fa1ef
to
7c7f99f
Compare
IkramMaalej
force-pushed
the
thumbnails-overlay
branch
from
7c7f99f
to
11440c0
Compare
oliver-stoehr
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5275