Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parentMappingFile configuration for catalog search configurations #5310

Merged

Conversation

solth
Copy link
Member

@solth solth commented Aug 20, 2022

Fixes #5305

@andre-hohmann
Copy link
Collaborator

@solth : Thanks for the PR. Technically, the first tests are successful! I can now create hierarchical processes with the parent mapping file.

However, i have observed a minor error: There are process identifier displayed to enable the selection the process to modify its metadata.
But instead of the superordinate process' identifier, it is shown the language label ger. Instead of ger, the identifier GA03538-00448249 should be displayed.

In the metadata and in the process title, the values are correct. This it seems to be rather a problem of display then a problem of functionality.
For the K10plus catalogue, the identifier are shown correctly.

FehlerHierarchie01

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good and are working but the possibility to use the translation system for the tool tip is missing - aside of missing automatic executed tests.

@solth solth force-pushed the opac-import-parent-mapping-file branch from f4d2fd6 to d9a2772 Compare August 22, 2022 17:39
@solth
Copy link
Member Author

solth commented Aug 22, 2022

However, i have observed a minor error: There are process identifier displayed to enable the selection the process to modify its metadata.
But instead of the superordinate process' identifier, it is shown the language label ger. Instead of ger, the identifier GA03538-00448249 should be displayed.

@andre-hohmann thank you very much for pointing this out. There is a bug in the logic for displaying catalog IDs in the process hierarchy during import that always expects the catalog ID metadata to be the first in the list of created kitodo:metadata nodes. Since your current parentMapping.xsl file seems to create an XML document where the first metadata in the list of metadata nodes is actually DocLanguage that metadata value is falsly taken as the catalog ID.

I will add a bugfix for this problem to this pull request.

@andre-hohmann
Copy link
Collaborator

@solth : With the new fix, the "ger-problem" is solved.
Thus, My tests are successful!

@solth solth merged commit 05ae6b1 into kitodo:master Aug 23, 2022
@solth solth deleted the opac-import-parent-mapping-file branch August 23, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable parent mapping for catalogue search again
3 participants