-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable parentMappingFile configuration for catalog search configurations #5310
Enable parentMappingFile configuration for catalog search configurations #5310
Conversation
0fc94d7
to
2687c4f
Compare
@solth : Thanks for the PR. Technically, the first tests are successful! I can now create hierarchical processes with the parent mapping file. However, i have observed a minor error: There are process identifier displayed to enable the selection the process to modify its metadata. In the metadata and in the process title, the values are correct. This it seems to be rather a problem of display then a problem of functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and are working but the possibility to use the translation system for the tool tip is missing - aside of missing automatic executed tests.
Kitodo/src/main/webapp/WEB-INF/templates/includes/importConfigurationEdit/rows/formatRow.xhtml
Outdated
Show resolved
Hide resolved
f4d2fd6
to
d9a2772
Compare
@andre-hohmann thank you very much for pointing this out. There is a bug in the logic for displaying catalog IDs in the process hierarchy during import that always expects the catalog ID metadata to be the first in the list of created I will add a bugfix for this problem to this pull request. |
@solth : With the new fix, the "ger-problem" is solved. |
Fixes #5305