Fix multi view state warning when searching #5445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase against master to fix broken Github CI builds! |
|
I can not review this pull request as I only noticed the messages in the |
|
The message was triggered when a user visits the search result page (for the first time) after performing a search via the global search input. However, it would only appear once. A second visit (or search) should not have produced the warning message again. A logout/login should allow to trigger the message again. |
There was a problem hiding this comment.
For the descriped way in #5445 (comment) the warning message did not appear anymore.
henning-gerhardt
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5444
Avoids Primefaces warning by checking whether a multi view state is available before clearing it.