Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async export #5482

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Fix async export #5482

merged 4 commits into from
Feb 15, 2023

Conversation

BartChris
Copy link
Collaborator

@BartChris BartChris commented Dec 9, 2022

resolves #5481
resolves #5008

This pull request tries to adress the problems outlined in the above issue by

  • not immediatly indicating a succesful export in case of an asynchronous export and prevent closing a workflow step after a failed automatic export
  • ensuring that the export status is correctly propagated through all the method calls involved
  • removing the static "export finished" message from the Desktop and Process list form to ensure that a success message is only displayed in case of an actual succesful export

@solth
Copy link
Member

solth commented Dec 12, 2022

@BartChris thanks for the pull request. Can you please rebase your branch against the current master to resolve the build issue caused by an outdated chrome driver?

@solth
Copy link
Member

solth commented Feb 15, 2023

@BartChris please rebase against current master since your PR is the next merge candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants