Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processes selection #5511

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Conversation

IkramMaalej
Copy link
Collaborator

@IkramMaalej IkramMaalej commented Jan 17, 2023

Fixes #5267
Fixes #4948
Fixes #4946

Copy link
Collaborator

@andre-hohmann andre-hohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could apply the two following scripts on 56 processes on 6 result pages.
action:addData key:singleDigCollection "value:Autographe"
action:deleteData key:singleDigCollection "value:Autographe"

From the users' perspective, the issue can be closed, if the PR is applied.

Maybe #4948 could be closed, too.

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and adding tests is good in any case.

@solth solth merged commit 3d57aa9 into kitodo:master Feb 20, 2023
@IkramMaalej IkramMaalej deleted the Processes-selection branch February 20, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants