Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA]: add CodeQL to CI #386

Closed
kitsudaiki opened this issue Jul 28, 2024 · 0 comments
Closed

[QA]: add CodeQL to CI #386

kitsudaiki opened this issue Jul 28, 2024 · 0 comments
Assignees
@kitsudaiki
Labels
Infrastructure Issues, which containing infrastructure updates in the webserver, ci-pipeline and so on L: ★☆☆ Expect low difficulty QA Any tasks, witch improve the quality of the code, documentation and so on Topic: Security security-bugs
Milestone
0.5.0

Comments

@kitsudaiki
Copy link
Owner

QA

Description

For more security CodeQL should be added to the CI. Because the default doesn't handle submodules and this way fails to build hanami, because the jwt-submodule is missing. So a workflow-file is necessary with the missing setting.

Acceptance Criteria

  • CodeQL was added by a new workflow-file to the CI

Additional Information

Blocked by

How to test
@kitsudaiki kitsudaiki added QA Any tasks, witch improve the quality of the code, documentation and so on Topic: Security security-bugs Infrastructure Issues, which containing infrastructure updates in the webserver, ci-pipeline and so on L: ★☆☆ Expect low difficulty labels Jul 28, 2024
@kitsudaiki kitsudaiki added this to the 0.5.0 milestone Jul 28, 2024
@kitsudaiki kitsudaiki self-assigned this Jul 28, 2024
kitsudaiki added a commit that referenced this issue Jul 28, 2024
@kitsudaiki
ci(#386): add CodeQL to CI
55d1b47 
Added new workflow-file for CodeQL.
kitsudaiki added a commit that referenced this issue Jul 28, 2024
@kitsudaiki
ci(#386): add CodeQL to CI
f4dadfc 
Added new workflow-file for CodeQL.
@kitsudaiki kitsudaiki mentioned this issue Jul 28, 2024
Merged
kitsudaiki added a commit that referenced this issue Jul 28, 2024
@kitsudaiki
ci(#386): add CodeQL to CI
5cf7d6a 
Added new workflow-file for CodeQL.
kitsudaiki added a commit that referenced this issue Jul 28, 2024
@kitsudaiki
ci(#386): add CodeQL to CI
ab56cd1 
Added new workflow-file for CodeQL.
kitsudaiki added a commit that referenced this issue Jul 28, 2024
@kitsudaiki
Merge pull request #388 from kitsudaiki/feat/add-codeql-to-ci
3f86f87 
related issues:
- #386
- #383
- #372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsudaiki kitsudaiki

Labels
Infrastructure Issues, which containing infrastructure updates in the webserver, ci-pipeline and so on L: ★☆☆ Expect low difficulty QA Any tasks, witch improve the quality of the code, documentation and so on Topic: Security security-bugs
Projects
OpenHanami
Status: Done
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@kitsudaiki