-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Black screen on Resurrection Remix OS 7.0.1 Beta 1 by OpenKirin.net #5
Comments
Can you give me logcat output? Which magisk version? |
This file was taken with Magisk 19.2 (19200) |
Hmm..
|
For me it looks good but there you go: magisk_log_20190523_005120.log
I tried
I did set that in the v10-foxy.sh sript, too, but no change.
Just a shoot into the blue but I found this in bootanimation from Resurrection Remix: Now I didn't look deep into your codes but maybe you need to wait for SurfaceFlinger, too? |
Interesting. So I added the same check, can you test it?
Is there a typo?
Can you set |
There are a few things happening now:
I'm not sure what's happening here (testing fixing typo + setting dmesg_restrict to 0) so I'll install your test version now but then I won't have time to test so please be patient. :) |
Okay, so these are my findings:
Anyway, there seems to be some race condition out of your control: Normally your bootscreen gets shown after the first reboot of a fresh install (of foxy-boot) but on the second boot and onwards sometimes foxy-boot shows up but most of the time the default boot screen comes up. Why I think this is a race condition? Because a magisk module replacing /system/media/bootanimation.zip works reliably (I'm using https://github.com/V10lator/RR-O-boot to test this) but then again the zip should be loaded a few ms after the bootanimation binary (as the stock bootanimation loads the zip). I think this isn't fixable on your end but would need Magisk to be tweaked? Please note that because of the race condition my testing is very limited (still not sure why sometimes no bootscreen comes up at all - maybe the race condition again? So android tries to load the binary while it gets replaced and for a time shorter than the blink of an eye there's no binary to load? I don't know Magisks internals good enough to confirm this so take it with a grain of salt) and I'll stop using foxy-boot now (not because it's not a great tool but because of the Magisk issue). |
Nice. That's easy to fix.
There was a post-fs stage in Magisk a long time ago which used cache partition instead of data partition, but this stage was removed.
Yes, it seems like a race and some Android 8/9 devices are affected since bootanimation can be started before post-fs-data. The cases when you get just the blank screen seem strange to me. Can you create a script in #!/system/bin/sh
count=0
while [ ! "`getprop 'init.svc.bootanim'`" = 'running' ]; do
sleep 0.1
count=$(($count + 1))
[ "$count" -lt 200 ] || break
done
if [ "`getprop 'init.svc.bootanim'`" = 'running' ]; then
pid="`pgrep -fox '/system/bin/bootanimation'`"
if [ -n "$pid" ] && [ ! "`readlink "/proc/$pid/exe"`" = '/system/bin/foxy-boot' ]; then
setprop 'ctl.restart' 'bootanim'
fi
fi |
That's a nice little script you wrote but I removed some other Magisk modules I don't really need and now foxy-boot works every time (and I have no more need for foxy-boot. Don't get me wrong: It's great but after seeing some boots I think I like an animated bootscreen more). Anyway, I might reinstall the modules and retest the next days as I love helping. :) |
Thanks! I'll wait. |
Hi @kitsunyan added file /sbin/.magisk/img/.core/service.d/50_foxy-workaround.sh with your script and it works for me with foxy-boot 1.4 from the regular Magisk module repository. (Without modifications (just foxy-boot 1.4 installed), i could see the log when shutting down the phone via power button, but not at boot - instead of foxy-boot there was the stock bootanimation) Do you need any logs? Btw. I am running Magisk 19.2 (19200) on a BQ Aquaris X Pro with stock firmware 2.7.1 (Android 8.1.0 Oreo, Kernel 3.18.71) edit: fixed typo edit2 (26.05., 10.40UTC): hm, weird, had the default animation one time (out of approx. 5 or 6 boots) |
@apnof if the module works with the scripts, that's fine. I'm going to include the final script into the module when I get a reliable solution.
Can you reproduce this problem? |
Unfortunately, it is pretty random. Sometimes i got foxy-boot, sometimes the stock screen. At the moment, it feels like a worse ratio. I don't have any knowledge about android debugging, but if you tell me how i can generate useful logs, maybe we can find the reason.. My phone does show the screen before the bootanimation pretty long, maybe the 2 seconds delay for restarting the bootanimation is to short? |
This service script is working perfectly for me so far 😄 . Had no success at all without it. |
Hi all, same here - service script fixed my issue (stock animation instead of FoxyBoot) on Mako (Nexus 4) running LineageOS 15.1 (Android 8.1.0). I was about to create an issue, but then I've found this one. Thanks for the work done on writing the module, and reporting the issue :) Side note: the same module works out-of-the-box on Lineageos 16.0 (Android 9) on Samsung Galaxy S4 VE (jfvelte) - no modification was needed. |
The phone shows just a black screen on boot (but it boots correctly). There are no linking errors. This is on a Honor 9 Lite (LLD-L21).
//EDIT:
/system/bin/bootanimation test
runs just fine.The text was updated successfully, but these errors were encountered: