Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about the compatibility of ChatImage with other mods #27

Closed
Xujiayao opened this issue Jan 25, 2024 · 5 comments
Closed

Questions about the compatibility of ChatImage with other mods #27

Xujiayao opened this issue Jan 25, 2024 · 5 comments

Comments

@Xujiayao
Copy link

Relates to Xujiayao/Discord-MC-Chat#211.

Hi. Writing in English here to facilitate language internationalization.

Please take a look at the referenced issue to get an understanding of the case. Several problems are mentioned there, and I would like to request if anything could be done on the ChatImage side.

Thank you.

@kitUIN
Copy link
Owner

kitUIN commented Jan 25, 2024

我看这位Ashy8682的说法是添加一个中间件用于将discord中的图片消息转为CICode发送到mc公屏中?

请问这是否存在难点?

@Xujiayao
Copy link
Author

Xujiayao commented Jan 26, 2024

image

Issue 里后面有提到说 Discord to Minecraft 可以借 MCDC 自定义配置解决,因此这块 ChatImage 不需要进行任何改动,而是 Minecraft to Discord 需要想办法。

Xujiayao/Discord-MC-Chat#211 (comment)

可以从这个 comment 开始看。

@kitUIN
Copy link
Owner

kitUIN commented Jan 26, 2024

Minecraft to Discord过程中

需要拆分CICode,提取出url

如果是file:///那就需要调用上传了吧
若服务器安装了ChatImage,则会有图片缓存在内存中

关于拆分CICode可以参考这段code

至于本地图片的话,有何好的想法?

@Xujiayao
Copy link
Author

我是觉得一个 mod 专门为了符合另一个 mod 的格式规范而进行修改可能并不是最实际的方法。要知道这样做可能会使 mod 代码变得越来越复杂,毕竟一旦接受一个请求,就会有无数类似请求。因此我主要希望探讨是否有一种更 general 的解决方案,这样后来者也不需要对此 mod 进行额外适配,这样大家也都受益嘛。<(^-^)>

@kitUIN

This comment was marked as off-topic.

@kitUIN kitUIN closed this as not planned Won't fix, can't repro, duplicate, stale Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants