Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LAPACK as a requirement #282

Closed
Connor-Bowley opened this issue Oct 24, 2022 · 4 comments · Fixed by #294
Closed

Remove LAPACK as a requirement #282

Connor-Bowley opened this issue Oct 24, 2022 · 4 comments · Fixed by #294

Comments

@Connor-Bowley
Copy link

Is it worthwhile to remove LAPACK (and by extension Fortran) for an easier build process and lower barrier to development.

GROUPS doesn't appear to need LAPACK (NIRALUser/GROUPS#40).

SPHARM-PDM uses it in one place that I have found. Could we replace the LAPACK call with something equivalent from Eigen (which is already in the superbuild and is used by other things like VTK) and then remove LAPACK (and Fortran) altogether?

@bpaniagua
Copy link
Contributor

yes, that would be fine, but we will have to benchmark SPHARM and make sure it continues working the same with the same dataset

@jcfr
Copy link
Member

jcfr commented Oct 24, 2022

GROUPS doesn't appear to need LAPACK

It turns out that it is currently required in the implementation of GroupwiseRegistration::eigenvalues.

See details at NIRALUser/GROUPS#40 (comment)

@jcfr
Copy link
Member

jcfr commented Oct 24, 2022

@jcfr jcfr linked a pull request Feb 21, 2023 that will close this issue
@jcfr
Copy link
Member

jcfr commented Feb 21, 2023

Closing. Both SPHARM-PDM and GROUPS were respectively updated by @allemangD in the following pull-requests:

And corresponding updates integrated into SlicerSALT through #294

@jcfr jcfr closed this as completed Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants