-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LAPACK as a requirement #282
Comments
yes, that would be fine, but we will have to benchmark SPHARM and make sure it continues working the same with the same dataset |
It turns out that it is currently required in the implementation of See details at NIRALUser/GROUPS#40 (comment) |
For reference, the lapack function Related links: |
Closing. Both SPHARM-PDM and GROUPS were respectively updated by @allemangD in the following pull-requests: And corresponding updates integrated into SlicerSALT through #294 |
Is it worthwhile to remove LAPACK (and by extension Fortran) for an easier build process and lower barrier to development.
GROUPS doesn't appear to need LAPACK (NIRALUser/GROUPS#40).
SPHARM-PDM uses it in one place that I have found. Could we replace the LAPACK call with something equivalent from Eigen (which is already in the superbuild and is used by other things like VTK) and then remove LAPACK (and Fortran) altogether?
The text was updated successfully, but these errors were encountered: