Changes for NDK23 #1427
Changes for NDK23 #1427
Conversation
The arch no longer used in url for NDK23+
|
Nice, thank you! buildozer/.github/workflows/android.yml Line 26 in 1279634 We'll also likely need to open an issue regarding the default NDK version in default.spec cause it will need to be changed when a new |
|
Did you mean modify the default.spec so the sed replacement would no longer be needed in the workflow? And yea the default ndk is as per python-for-android, if changing that comment in the spec I would also change the target api - is there a consensus there? Was thinking 30; unless p4a already defaults to another |
Nope. I was referring to the
Changing the target API would be nice, but maybe in another PR, just to keep things separated. Approved the CI run, let's see if we have a green flag. Thank you again! |
|
That's what was confusing me yea, on the target api - its the 27 used in p4a tests I suppose that's holding things up. Probably wait for that before changing here. Worth updating the android.ndk comment? (even though version is controlled by python-for-android in most cases) |
|
Looks that all the relevant tests are passing (macOS Android / Integration is expected to fail). |
* Add support --res_xml option in p4a * res_xml paths are relative to buildozer.spec * Changes for NDK23 (kivy#1427) The arch no longer used in url for NDK23+ * Our self-hosted Apple Silicon runner now has been migrated to actions/runner v2.292.0 which now supports arm64 natively (kivy#1438) * use p4a --add-source instead of manual copy (kivy#1450) Currently, android.add_src does not work anymore. Using --add-source from p4a make it work again. * fix aar build (kivy#1444) * fix aar build * update default.spec to include 'debug_artifact' * Updates default buildozer.spec NDK from 19b to 23b (kivy#1462) * Update CHANGELOG and prepare release 1.4.0 (kivy#1463) * Bump version to 1.4.1.dev0 (kivy#1464) * p4a prerequisites install should be done in non-interactive mode during CI builds. (kivy#1465) * Avoid the usage of `shell=True` in Popen, which could lead to potential security risks. (kivy#1435) * Removes (where possible) the usage of shell=True in Popen * Fixes (needs check on runtime) adb + add a solution for p4a.extra_args * Change the logic to auto accept the SDK licenses, to avoid the shell=True usage * Removes six dependency in tests (kivy#1475) * Fixes some E275 - assert is a keyword. (kivy#1495) * Fix presplash color (kivy#1497) Buildozer wont build if a presplash color is set, this should fix it as descrived in kivy#1487 * Show output during aab support check, as p4a may require the user input (kivy#1494) * Update installation.rst (kivy#1500) * Update installation.rst Update jdk and Ubuntu versions. Update WSL usage instructions. * Update installation.rst * Update docs/source/installation.rst Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> * Update docs/source/installation.rst Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> Co-authored-by: Eero af Heurlin <eero.afheurlin@iki.fi> Co-authored-by: HyTurtle <81598434+HyTurtle@users.noreply.github.com> Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> Co-authored-by: Mathieu Virbel <mat@meltingrocks.com> Co-authored-by: Mikhail Zakharov <mzakharo@users.noreply.github.com> Co-authored-by: Akshay Arora <akshayaurora@gmail.com> Co-authored-by: Apacelus <46828271+apacelus@users.noreply.github.com> Co-authored-by: RobertF <34464649+RobertFlatt@users.noreply.github.com>
The arch is no longer used in the download url for NDK23+