p4a prerequisites install should be done in non-interactive mode during CI builds. #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craulback
added a commit
to Craulback/buildozer
that referenced
this pull request
Sep 27, 2022
* Add support --res_xml option in p4a * res_xml paths are relative to buildozer.spec * Changes for NDK23 (kivy#1427) The arch no longer used in url for NDK23+ * Our self-hosted Apple Silicon runner now has been migrated to actions/runner v2.292.0 which now supports arm64 natively (kivy#1438) * use p4a --add-source instead of manual copy (kivy#1450) Currently, android.add_src does not work anymore. Using --add-source from p4a make it work again. * fix aar build (kivy#1444) * fix aar build * update default.spec to include 'debug_artifact' * Updates default buildozer.spec NDK from 19b to 23b (kivy#1462) * Update CHANGELOG and prepare release 1.4.0 (kivy#1463) * Bump version to 1.4.1.dev0 (kivy#1464) * p4a prerequisites install should be done in non-interactive mode during CI builds. (kivy#1465) * Avoid the usage of `shell=True` in Popen, which could lead to potential security risks. (kivy#1435) * Removes (where possible) the usage of shell=True in Popen * Fixes (needs check on runtime) adb + add a solution for p4a.extra_args * Change the logic to auto accept the SDK licenses, to avoid the shell=True usage * Removes six dependency in tests (kivy#1475) * Fixes some E275 - assert is a keyword. (kivy#1495) * Fix presplash color (kivy#1497) Buildozer wont build if a presplash color is set, this should fix it as descrived in kivy#1487 * Show output during aab support check, as p4a may require the user input (kivy#1494) * Update installation.rst (kivy#1500) * Update installation.rst Update jdk and Ubuntu versions. Update WSL usage instructions. * Update installation.rst * Update docs/source/installation.rst Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> * Update docs/source/installation.rst Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> Co-authored-by: Eero af Heurlin <eero.afheurlin@iki.fi> Co-authored-by: HyTurtle <81598434+HyTurtle@users.noreply.github.com> Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com> Co-authored-by: Mathieu Virbel <mat@meltingrocks.com> Co-authored-by: Mikhail Zakharov <mzakharo@users.noreply.github.com> Co-authored-by: Akshay Arora <akshayaurora@gmail.com> Co-authored-by: Apacelus <46828271+apacelus@users.noreply.github.com> Co-authored-by: RobertF <34464649+RobertFlatt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
python-for-androidCI (see) , also the CI runs for Android inbuildozerneed to havePYTHONFORANDROID_PREREQUISITES_INSTALL_INTERACTIVEset to0.This is needed as
python-for-androidnow handles a prerequisites check + advice + install (on macOS, coming soon to other platforms), and expects input from the user.buildozerdocs.