Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation.rst #1500

Merged
merged 4 commits into from Aug 30, 2022
Merged

Update installation.rst #1500

merged 4 commits into from Aug 30, 2022

Conversation

RobertFlatt
Copy link
Contributor

Update jdk and Ubuntu versions.
Update WSL usage instructions.

Update jdk and Ubuntu versions.
Update WSL usage instructions.
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Left 2 minor suggestions, but absolutely LGTM. Thank you! ❤️

I'm wondering if it's better to also include a section that advises using a full-featured VM, instead of WSL*, but that's another topic. 🧐

docs/source/installation.rst Outdated Show resolved Hide resolved
docs/source/installation.rst Outdated Show resolved Hide resolved
RobertFlatt and others added 2 commits August 30, 2022 06:45
Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
@RobertFlatt
Copy link
Contributor Author

Thank you for the improvements.

One question, is Cython still a user install requirement? I ask because somewhere I noticed Buildozer using Cython 3 - which means it downloads its own version. Can Cython be removed here?

Yes, any VE documentation should be platform independent. (IMO for somebody who installed WSL just to run Buildozer, a VE is complexity without utility - which is why I removed it).

@misl6
Copy link
Member

misl6 commented Aug 30, 2022

One question, is Cython still a user install requirement? I ask because somewhere I noticed Buildozer using Cython 3 - which means it downloads its own version. Can Cython be removed here?

If Cython doesn't get installed by the user buildozer will fail here ( something similar happens on the iOS side ):

checkbin('Cython (cython)', 'cython')

And nope, python-for-android doesn't install (or give instructions to buildozer via install reqs ) Cython.

python-for-android automatically installs Cython only for regular packages installations here:

https://github.com/kivy/python-for-android/blob/28151d1864df9564ee796910f38a995b54d73631/pythonforandroid/build.py#L715

(Previously [~3/4 years ago ] we were using the system-wide cython install, so that's why)

Yeah, we may need to do some renovations 🏡 , but now is still a user install requirement 😄.

Yes, any VE documentation should be platform independent. (IMO for somebody who installed WSL just to run Buildozer, a VE is complexity without utility - which is why I removed it).

Agree!

@misl6
Copy link
Member

misl6 commented Aug 30, 2022

Thanks again!

@misl6 misl6 merged commit 9503f5f into kivy:master Aug 30, 2022
@misl6 misl6 mentioned this pull request Aug 30, 2022
Craulback added a commit to Craulback/buildozer that referenced this pull request Sep 27, 2022
* Add support --res_xml option in p4a

* res_xml paths are relative to buildozer.spec

* Changes for NDK23 (kivy#1427)

The arch no longer used in url for NDK23+

* Our self-hosted Apple Silicon runner now has been migrated to actions/runner v2.292.0 which now supports arm64 natively (kivy#1438)

* use p4a --add-source instead of manual copy (kivy#1450)

Currently, android.add_src does not work anymore.
Using --add-source from p4a make it work again.

* fix aar build (kivy#1444)

* fix aar build

* update default.spec to include 'debug_artifact'

* Updates default buildozer.spec NDK from 19b to 23b (kivy#1462)

* Update CHANGELOG and prepare release 1.4.0 (kivy#1463)

* Bump version to 1.4.1.dev0 (kivy#1464)

* p4a prerequisites install should be done in non-interactive mode during CI builds. (kivy#1465)

* Avoid the usage of `shell=True` in Popen, which could lead to potential security risks. (kivy#1435)

* Removes (where possible) the usage of shell=True in Popen

* Fixes (needs check on runtime) adb + add a solution for p4a.extra_args

* Change the logic to auto accept the SDK licenses, to avoid the shell=True usage

* Removes six dependency in tests (kivy#1475)

* Fixes some E275 - assert is a keyword. (kivy#1495)

* Fix presplash color (kivy#1497)

Buildozer wont build if a presplash color is set, this should fix it as descrived in kivy#1487

* Show output during aab support check, as p4a may require the user input (kivy#1494)

* Update installation.rst (kivy#1500)

* Update installation.rst

Update jdk and Ubuntu versions.
Update WSL usage instructions.

* Update installation.rst

* Update docs/source/installation.rst

Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>

* Update docs/source/installation.rst

Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>

Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>

Co-authored-by: Eero af Heurlin <eero.afheurlin@iki.fi>
Co-authored-by: HyTurtle <81598434+HyTurtle@users.noreply.github.com>
Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
Co-authored-by: Mathieu Virbel <mat@meltingrocks.com>
Co-authored-by: Mikhail Zakharov <mzakharo@users.noreply.github.com>
Co-authored-by: Akshay Arora <akshayaurora@gmail.com>
Co-authored-by: Apacelus <46828271+apacelus@users.noreply.github.com>
Co-authored-by: RobertF <34464649+RobertFlatt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants