Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

adding hover over enhancement #172

Merged
merged 4 commits into from
Jan 26, 2016
Merged

adding hover over enhancement #172

merged 4 commits into from
Jan 26, 2016

Conversation

kiok46
Copy link
Contributor

@kiok46 kiok46 commented Jan 22, 2016

Earlier in Kivy-Designer we had to click on each DesignerActionGroup button to open it, we couldn't open it just by hovering over it via mouse.
This pr solves this.

@aron-bordin
Copy link
Member

Hi @kiok46 ,
Your pr looks good.

Please, just add some comments/docs about these new class attributes(like any property, what it does and its type) and new methods. And if possible, some source code comments may help new contributors ;)

Thx

@kiok46
Copy link
Contributor Author

kiok46 commented Jan 23, 2016

Hi! @aron-bordin, see if it's ok now :)

@aron-bordin
Copy link
Member

Testing it, I realized that it's necessary to check if there is an open popup, or just identify if all action groups are closed to disable to_open

For example, go to Run -> Edit Profiles .... You will see a popup. Now, move the mouse on action bar. The action groups are opening. In such cases to_open should be set to False to avoid these issues.

@kiok46
Copy link
Contributor Author

kiok46 commented Jan 24, 2016

Hey! @aron-bordin
I have made the changes, tell me if you want me to squash them.

@aron-bordin aron-bordin added this to the 0.1 milestone Jan 26, 2016
aron-bordin added a commit that referenced this pull request Jan 26, 2016
adding hover over enhancement
@aron-bordin aron-bordin merged commit 38ebf6d into kivy:master Jan 26, 2016
@aron-bordin
Copy link
Member

Awesome @kiok46 , thx again 👍

@kiok46 kiok46 deleted the hover_over branch January 26, 2016 19:02
@kiok46
Copy link
Contributor Author

kiok46 commented Jan 26, 2016

@aron-bordin I enjoyed 😄 , welcome

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants