Skip to content

Commit

Permalink
Fix all ScreenManagers sharing the same transition
Browse files Browse the repository at this point in the history
All ScreenManagers share the same SlideTransition instance by default, which can cause some timing issues and other weirdness (and is more generally a bad idea). This PR fixes the issue.
  • Loading branch information
Cheaterman committed Sep 6, 2017
1 parent 78a4206 commit 2066b6d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion kivy/uix/screenmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,7 @@ class ScreenManager(FloatLayout):
to None.
'''

transition = ObjectProperty(SlideTransition(), baseclass=TransitionBase)
transition = ObjectProperty(baseclass=TransitionBase)
'''Transition object to use for animating the transition from the current
screen to the next one being shown.
Expand Down Expand Up @@ -966,6 +966,7 @@ def _get_screen_names(self):
def __init__(self, **kwargs):
super(ScreenManager, self).__init__(**kwargs)
self.fbind('pos', self._update_pos)
self.transition = SlideTransition()

def _screen_name_changed(self, screen, name):
self.property('screen_names').dispatch(self)
Expand Down

0 comments on commit 2066b6d

Please sign in to comment.