Allow Line.points definition to be a mix of lists/tuples #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue kivy#3481 Line.points can be defined as list of lists, tuples and coordinates (float values) setter method modified to check each element of the argument list and append it to self._points accordingly Line example file /examples/canvas/line.py updated with the new possible way of defining points
Forgot to remove it after experimenting, sorry 👅
| def __set__(self, points): | ||
| self._points = list(points) | ||
| tmp = [] | ||
| for p in points: |
There was a problem hiding this comment.
I haven't tested, but it looks like a slow implementation. I think mixing lists/tuples with plain values is not a priority. points could be either a plain list/tuple, a list/tuple of lists, a list/tuple of tuples, or a list/tuple of lists and tuples (possibly mixed). This way, a faster algo could be used, something like what @kived proposed in the issue.
Ignores the case when self._points is a mix of list/tuple/float Only works in cases where self._points is a list of iterables
dessant
added
the
Status: On-hold
|
@dessant I made the changes you requested. I agree the previous algorithm was slower. Given the conditions you mentioned we can use kived's algorithm |
| def __set__(self, points): | ||
| self._points = list(points) | ||
| import itertools |
There was a problem hiding this comment.
Is there a reason for doing the import in the method?
There was a problem hiding this comment.
I just realised that will slow things down :P
Moved import to top of module Added case when points is a plain list
|
👍 |
dessant
removed
the
Status: On-hold
dessant
added a commit
that referenced
this pull request
Feb 1, 2016
Allow Line.points definition to be a mix of lists/tuples
This was referenced Feb 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #3481
Line.pointscan be defined as list of lists, tuples and coordinates (float values).Setter method modified to check each element of the argument list and append it to
self._pointsaccordingly.Line example file /examples/canvas/line.py updated with the new possible way of defining points.
Note: appending a tuple to
pointscauses problems