Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Inspector module, fix children order for ModalView #5378

Merged
merged 4 commits into from
Sep 12, 2017

Conversation

KeyWeeUsr
Copy link
Contributor

ref #5369

The PR still needs the last part of unittest i.e. testing multiple ModalViews or Popups opened and check if they stack properly as LIFO.

@KeyWeeUsr
Copy link
Contributor Author

KeyWeeUsr commented Sep 11, 2017

meh, the tests will crash because of Travis 😢

The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over).

The job has been terminated

Edit: Resolved with silencing KV lang specific TRACE type of logging in this particular TestCase. Basically tracing KV isn't necessary for this particular test as the asserting checks for values modified by the python side only i.e. if a widget is selected, if the on_* event works, etc.

@KeyWeeUsr
Copy link
Contributor Author

Tests pass, the additional change in inspector.py closes #5369.

@KeyWeeUsr KeyWeeUsr merged commit f32bb16 into master Sep 12, 2017
@KeyWeeUsr KeyWeeUsr deleted the fix_popup_inspector branch September 12, 2017 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant