[core/video]Disabled set_volume() in core.video.ffpyplayer play() function. Fix for #6210

[misl6]

As mentioned in issue #6210 , on Android the video and videoplayer works only once.

Actual implementation on the ffpyplayer provider in core.video.ffpyplayer sets the volume just after the creation of the MediaPlayer.

After some investigation, seems that, the second usage of the Video/VideoPlayer w/ ffpyplayer takes more time to instantiate the AudioTrack that it looks like to be async.

In order to get my app running correctly I've commented out (as proposed in this PR) the set_volume call in the play() function.

I think that is not to be considered as the final fix ( we need to investigate further on the ffpyplayer implementation ), but should be merged ASAP, in order to temporarily solve this issue for all the affected users.

[Danapessach]

I changed it locally after the build and it solved the issue

[matham]

I'm not sure how disabling setting the volume solves the crash? I don't see any mention of that line in the error message. In any case, you can pass the volume parameter to ff_opts instead of calling set_volume, rather than just commenting it out.

See the option here: https://github.com/matham/ffpyplayer/blob/master/ffpyplayer/player/player.pyx#L245

[tito]

Yep, don't merge this, because even if it solve a possible crash, it also break the wanted volume at the start.

[tito]

Find an alternative to ensure the volume of the video is the one set by the user, like ff_opts explained by @matham

[Danapessach]

I'm quite sure the volume does't matter when the video doesn't work at all...
This is why it was suggested as a temporary solution.

[matham]

It does work generally, just not when playing a second time, or a perhaps when playing a particular file. This will break it for everyone even for cases that do currently work because the volume will stop working.

[Danapessach]

The problem happened for me with all files - different videos, different formats...

For me the volume worked OK after implementing the fix with the original volume of the video.

For you, when you tried this fix the volume didn't work at all?

[misl6]

@tito @matham I've added volume inff_opts.
Consider that as a temp fix, I've scheduled some big improvements to the provider.

Changes were implemented