-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger: Add encoding #6910
Logger: Add encoding #6910
Conversation
to be sure, could you write a simple test showing the issue on your machine, and check that the fixed code works with it? bonus points if that's a unittest we can run in CI, that would be most comforting :). |
To me, the whole thing should actually be unit tested to show the point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for unit testing it 💪
Whoever will merge should think about squashing
Fix for #6909
Not sure if this can lead to infinite loops.