Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger: Add encoding #6910

Merged
merged 8 commits into from
Jun 1, 2020
Merged

Logger: Add encoding #6910

merged 8 commits into from
Jun 1, 2020

Conversation

sanderland
Copy link
Contributor

Fix for #6909

Not sure if this can lead to infinite loops.

        except Exception as e:
            Logger.exception("Unexpected exception in logging", e)

Sander Land added 2 commits June 1, 2020 14:24
@tshirtman
Copy link
Member

to be sure, could you write a simple test showing the issue on your machine, and check that the fixed code works with it? bonus points if that's a unittest we can run in CI, that would be most comforting :).

@AndreMiras
Copy link
Member

To me, the whole thing should actually be unit tested to show the point.
It shouldn't be that hard to add a test calling the _write_message() method showing that Logger.exception() is then getting called

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for unit testing it 💪
Whoever will merge should think about squashing

@matham matham merged commit 4b450cc into kivy:master Jun 1, 2020
@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham mentioned this pull request Oct 30, 2020
@matham matham changed the title logger fix Logger: Add encoding Dec 9, 2020
@matham matham added the Component: core-app app, clock, config, inspector, logger, resources, modules, clock, base.py label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: core-app app, clock, config, inspector, logger, resources, modules, clock, base.py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants