Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Property: Use ObservableList as internal storage for ColorProperty #6930

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Property: Use ObservableList as internal storage for ColorProperty #6930

merged 3 commits into from
Jun 9, 2020

Conversation

pythonic64
Copy link
Contributor

No description provided.

@pythonic64 pythonic64 requested a review from matham June 9, 2020 19:29
@pythonic64 pythonic64 mentioned this pull request Jun 9, 2020
Merged
matham
matham requested changes Jun 9, 2020
View reviewed changes
Copy link
Member

@matham matham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some tests? It should be easy with pytest.

@pythonic64 pythonic64 merged commit cf88ec5 into kivy:master Jun 9, 2020
@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham changed the title Use ObservableList as internal storage for ColorProperty Property: Use ObservableList as internal storage for ColorProperty Dec 9, 2020
@matham matham added the Component: core-widget properties, eventdispatcher, widget.py, animation label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matham matham matham approved these changes

Assignees
No one assigned
Labels
Component: core-widget properties, eventdispatcher, widget.py, animation
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pythonic64 @matham