Base: Rename slave to embedded
#6937
Conversation
There was a problem hiding this comment.
I think a more accurate word to use here is embedded as that describes much more precisely the meaning of the mode. So please use that instead.
Also, there's no need to keep the word slave for backward compact because (a) this is 2.0.0 when we're freer to break that, but more importantly, (b) I highly doubt anyone is using this mode much, except in a very specialized context, so changing the keyword will almost certainly not break any existing usage.
|
I support changing this to about anything that is less harmful than the current option, puppet, managed, embedded, delegated_clock, whatever, let's make it happen before 2.0 :) and yeah, i'd drop the alias as well, we can document that in release notes, it's a small enough change that people can update their code if they upgrade kivy. If we think it's really necessary to keep, i would add a deprecation warning (and like a 5s sleep, so people can't miss it), not just silently accept it. |
|
Sure, |
|
Sorry to bother you with another review request, it bothered me that there were 2 commits instead of 1 ;) |
|
No worries. But it would have been ok because we can squash commits in the GitHub UI. |
See https://tools.ietf.org/id/draft-knodel-terminology-00.html for reference. See kivy/kivy#6937 for the technical implications at play here.
|
To the downvoters... Is it really such a big deal? |
matham
added
the
Component: core-app
Pursuant to the first point of the code of conduct, this pull request renames the
slaveswitch inrunTouchApptoembedded.For reference, the IETF has written about the troubling implications of the master/slave metaphor.