Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics: Only check for threading issues once graphics is initialized #7455

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

matham
Copy link
Member

@matham matham commented Mar 30, 2021

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

This fixes an issue, where if you created graphics instructions before kivy gl thread was initialized (which seems to happen with ScrollView), it would the error that you're accessing the graphics from the wrong thread. This fixes so it only does it once the thread has been initialized.

While technically this would allow people to create graphics from another thread before the kivy thread was initialized and it wouldn't warn about it. But it shouldn't happen often and this would still warn for the most common situation, while not warning on false positive.

@matham matham added the Component: graphics kivy/graphics label Mar 30, 2021
@matham matham added this to the 2.1.0 milestone Mar 30, 2021
@matham matham merged commit 2c51820 into master Mar 31, 2021
@matham matham deleted the matham-patch-1 branch March 31, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: graphics kivy/graphics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants