Fix crash in Android Notification (SDK_INT >= 26) #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the following error appearing in SDK_INT >= 26: ``` JNI DETECTED ERROR IN APPLICATION: bad arguments passed to java.lang.Object android.app.Activity.getSystemService(java.lang.String) ``` It seems that the error is happening because there is a bug in pyjnius where `getSystemService(java.lang.Class)` is not recognized. So, instead of using `getSystemService(manager)`, `_get_notification_service` is used, which returns `(NotificationManager) getSystemService(Context.NOTIFICATION_SERVICE)`.
|
This fix worked for me! Had the bad arguments error and this fixed it. |
|
Works for me as well on Android 10, thanks a lot! |
|
@franccisco Thanks :-) |
ghost
deleted the
AndreMiras
pushed a commit
to AndreMiras/plyer
that referenced
this pull request
Apr 24, 2023
This commit fixes the following error appearing in SDK_INT >= 26: ``` JNI DETECTED ERROR IN APPLICATION: bad arguments passed to java.lang.Object android.app.Activity.getSystemService(java.lang.String) ``` It seems that the error is happening because there is a bug in pyjnius where `getSystemService(java.lang.Class)` is not recognized. So, instead of using `getSystemService(manager)`, `_get_notification_service` is used, which returns `(NotificationManager) getSystemService(Context.NOTIFICATION_SERVICE)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the following error appearing in SDK_INT >= 26:
It seems that the error is happening because there is a bug in pyjnius
where
getSystemService(java.lang.Class)is not recognized. So, insteadof using
getSystemService(manager),_get_notification_serviceisused, which returns
(NotificationManager) getSystemService(Context.NOTIFICATION_SERVICE).Fixes #504, Fixes #533