Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored output in Xcode #357

Closed
Ashton-W opened this issue Aug 30, 2013 · 14 comments
Closed

Colored output in Xcode #357

Ashton-W opened this issue Aug 30, 2013 · 14 comments

Comments

@Ashton-W
Copy link

Colored output in the Xcode console could be supported by using XcodeColors, an example of another project using it is CocoaLumberjack.


  1. https://github.com/robbiehanson/XcodeColors
  2. https://github.com/robbiehanson/CocoaLumberjack/wiki/XcodeColors
@supermarin
Copy link

@Ashton-W we don't plan to add these dependencies atm, as we're using the default OCUnit's test runner.

Maybe when the <redacted> gets released, this could get supported by apple.
Otherwise, we can reopen this.

@Ashton-W
Copy link
Author

Ashton-W commented Sep 5, 2013

My understanding is that an environment variable XcodeColors can be
checked and then special characters can be included in the console messages.

Assuming this is the case, and it can be done with OCUnits output, would
this be an accepted feature?

I may work on it anyway for fun, but I'd like to aim to get a pull request
accepted.

Sent from my iPhone

On 05/09/2013, at 6:02 PM, Marin Usalj notifications@github.com wrote:

@Ashton-W https://github.com/Ashton-W we don't plan to add these
dependencies atm, as we're using the default OCUnit's test runner.

Maybe when the gets released, this could get supported by apple.
Otherwise, we can reopen this.


Reply to this email directly or view it on
GitHubhttps://github.com/allending/Kiwi/issues/357#issuecomment-23849765
.

@supermarin
Copy link

@Ashton-W sure, if you feel like doing a PR, take the gun :)

There are also other team members that'll review it.

@Ashton-W
Copy link
Author

Ashton-W commented Sep 8, 2013

Requesting feedback, I've got a working commit in my fork Ashton-W@5f5efac I'll tidy it up before the PR.

Xcode console
Xcode console

@Ashton-W
Copy link
Author

Ashton-W commented Sep 9, 2013

https://github.com/Ashton-W/Kiwi/compare/feature;XcodeColors

Fixed some silly bugs. Added more and better colors.

screen shot 2013-09-09 at 9 10 30 pm

@alexiscreuzot
Copy link

This seems nice. Kiwi could definitely use some output enhancements (colors, separators...).

@winstonwolff
Copy link

I add a vote for colorized output to Kiwi.

@abelnation
Copy link

+1

1 similar comment
@STAR-ZERO
Copy link

+1

@bengotow
Copy link

bengotow commented May 2, 2014

+1 - Kiwi doesn't necessarily need to require XcodeColors - but I'd love to be able to turn this on.

@Ashton-W
Copy link
Author

Ashton-W commented May 3, 2014

@bengotow this adds no dependency, the XcodeColors environment variable in Xcode turns this on.

@Ashton-W
Copy link
Author

Ashton-W commented May 3, 2014

@supermarin can we get this reopened?

@modocache
Copy link
Member

My understanding is that an environment variable XcodeColors can be
checked and then special characters can be included in the console messages.

@Ashton-W Part of issue #306, Kiwi 3.0, is making Kiwi output extensible. Once we have extensible formatters, anyone can build a custom Kiwi formatter--including one that supports the XcodeColors environment variable. One idea for implementing those formatters has been submitted as pull request #449.

I'm not thrilled with the idea of Kiwi supporting XcodeColors natively, but since there seems to be a bunch of support for the idea, I wouldn't be against at least reviewing a pull request. If it's a clean implementation, I'd consider getting on board.

@Ashton-W
Copy link
Author

Ashton-W commented May 4, 2014

I'll follow #449 and move XcodeColors support to that as it develops.

In the meantime, @modocache I have opened a PR for you to review at your leisure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants