Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChromePie doesn't work with 93.x #345

Closed
kkuhle opened this issue Aug 17, 2021 · 4 comments
Closed

ChromePie doesn't work with 93.x #345

kkuhle opened this issue Aug 17, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@kkuhle
Copy link

kkuhle commented Aug 17, 2021

Describe the bug
Xposed module ChromePie for Chromium browsers does not work on new versions

To Reproduce

  1. Have xposed on a device with the ChromePie module enabled for KiwiBrowser [version Git210216Gen570536402 (2102162)] (activation of ChromePie works)
  2. Upgrade to a newer version (93.x+) of KiwiBrowser from the Play Store
  3. Observe ChromePie no longer works

Expected behavior
ChromePie should be able to activate. It works on all other Chromium browsers (including the old KiwiBrowser) that I've tested.

Screenshots
If applicable, add screenshots to help explain your problem.

  • old kiwibrowser works

  • new kiwibrowser doesn't work

  • enabled in lsposed along with some other Chromium browsers that work

Smartphone (please complete the following information):

  • Device: OnePlus 6T running Havoc OS
  • Application version
    Kiwi Browser 93.0.4577.39
  • Operating system
    Android 11; ONEPLUS A6013 Build/RQ2A.210405.005

Additional context
Digging through the settings, I wonder if it could have anything to do with Settings > Accessibility > Edge swipe configuration. Either value I use to configure this, ChromePie will not activate. When I use Google Chrome, the pie function activates, but occasionally I still see the little arrow (annoying).

When I turn off Swipe Navigation in Edge (Settings > Browsing options > Swipe Navigation) the pie still works. It also still works with it on. Anyway, considering the results in Edge, maybe the setting makes no difference, but I thought it was worth mentioning.

One other point that might be worth mentioning is that every other modern Android Chromium browser I've tested is 92.x whereas KiwiBrowser is 93.x. Perhaps this version is breaking ChromePie's ability to activate.

Edit: I tested Google Chrome Beta which gives me an Application Version of Chrome Beta 93.0.4577.37 so I don't think this is it (I also tested all other KiwiBrowser versions on 93 with no different result)

@kkuhle kkuhle added the bug Something isn't working label Aug 17, 2021
@gnadelwartz
Copy link

gnadelwartz commented Aug 18, 2021

Chrome pie seems not to be simply a Chrome extension, at least from what I understand after a google search.
as kiwi can not adjust to every external framework, it may help to file a bug request on their github repository (also)

it should be much easier to fix a bug (in Kiwi and/or pie) if the chrome pie guys are involved

@kkuhle
Copy link
Author

kkuhle commented Aug 18, 2021

You're right, @gnadelwartz it isn't a Chrome extension at all. It's a really nice Xposed module that hasn't been updated/maintained since Jul 22, 2018. I can file a bug request on the repo https://github.com/JayT5/ChromePie but I believe it's been totally abandoned. I will do it anyway in case the developer decides to pick it up again.

ChromePie works on every other Android Chromium browser I've tried, so I'm suspicious about some changed in the latest KiwiBrowser versions (like maybe how gesture navigation has been modified) that prevent it from working.

Moving the toolbar down to the bottom of the screen is a very useful feature, but then I can't swipe across the address bar to quickly change tabs (maybe I could without Android 11 gesture navigation) or easily swipe down to show the tab switcher (instead, we can swipe up, but I find myself accidentally going home too often to use this setting).

Additionally, ChromePie vs using the Chromium menu is just a lot quicker and I don't fumble around like I do in the Chromium menu trying to find things that may have moved because of a recent extension I added, etc.

Edit: created bug with ChromePie github 42

@d3ward
Copy link
Collaborator

d3ward commented Sep 27, 2021

As this seems to be more a framework bug rather than Kiwi , the issue will be closed

@d3ward d3ward closed this as completed Sep 27, 2021
@kkuhle
Copy link
Author

kkuhle commented Sep 29, 2021

This seems to be fixed with the September 21st update. I noticed the browser looks like kiwibrowser classic where the bug was not present. Wondering if the API level was decreased to avoid some bugs such as 325. Not complaining. Glad that it's working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants