Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pylint and fix all warnings and errors #171

Closed
atodorov opened this issue Jan 8, 2018 · 0 comments · Fixed by #2287
Closed

Enable pylint and fix all warnings and errors #171

atodorov opened this issue Jan 8, 2018 · 0 comments · Fixed by #2287
Labels
enhancement help wanted high priority

Comments

@atodorov
Copy link
Member

atodorov commented Jan 8, 2018

We need to enable pylint for Kiwi and fix all of its complaints (which are 3500 at least).
@asankov asankov mentioned this issue Mar 21, 2018
Merged
atodorov added a commit that referenced this issue Nov 14, 2018
@atodorov
Disable duplicate-code pylint check. Refs #171
8a552ab 
it appears this check produces more false positives than discover
real problems so we silence it. CodeClimate also supports
duplicate/similar code discovery and it appears to be more
reliable so stick with CodeClimate for now.
atodorov added a commit that referenced this issue Nov 14, 2018
@atodorov
Disable duplicate-code pylint check. Refs #171
5613a56 
it appears this check produces more false positives than discover
real problems so we silence it. CodeClimate also supports
duplicate/similar code discovery and it appears to be more
reliable so stick with CodeClimate for now.
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jun 29, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
4f3776a
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jun 29, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
ee22452
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jun 29, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
65c9516
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jun 29, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
90efc27
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jun 29, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
4f6a6f1
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jun 30, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
8d620d6
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jun 30, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
3ff1030
atodorov pushed a commit that referenced this issue Jul 1, 2019
@SvetlomirBalevski @atodorov
Disable pylint message for unnecessary checks. Refs #171
bae42cd
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jul 5, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
b62edf0
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jul 5, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
2814a09
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jul 5, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
ad3eee2
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jul 5, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
b83e1ae
@SvetlomirBalevski SvetlomirBalevski mentioned this issue Jul 5, 2019
Merged
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jul 6, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
8437b8d
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jul 6, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
04b0b2d
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jul 6, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
603b791
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Jul 6, 2019
@SvetlomirBalevski
Disable pylint message for unnecessary checks. Refs kiwitcms#171
bdbabd9
atodorov pushed a commit that referenced this issue Jul 7, 2019
@SvetlomirBalevski @atodorov
Disable pylint message for unnecessary checks. Refs #171
429fd3d
@SvetlomirBalevski SvetlomirBalevski mentioned this issue Jul 17, 2019
Closed
@SvetlomirBalevski SvetlomirBalevski mentioned this issue Jul 31, 2019
Merged
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Aug 7, 2019
@SvetlomirBalevski
Disable pylint checks for several views,
96486c7 
because those views are only selecting/reading
data but not modifying it. Refs kiwitcms#171
SvetlomirBalevski added a commit to SvetlomirBalevski/Kiwi that referenced this issue Aug 8, 2019
@SvetlomirBalevski
Disable pylint checks for several views,
249e4cd 
because those views are only selecting/reading
data but not modifying it. Refs kiwitcms#171
atodorov added a commit that referenced this issue Apr 11, 2020
@atodorov
Don't overwrite ~/.tcms.conf when testing. Refs #171
7f49d08
atodorov added a commit that referenced this issue Apr 11, 2020
@atodorov
Convert NewPlanForm into ModelForm. Refs #1384, #171
43f30d7
atodorov added a commit that referenced this issue Apr 11, 2020
@atodorov
api: Convert TestPlan.create() & TestPlan.update() to ModelForm
0d3fb59 
Refs #1384, #171
atodorov added a commit that referenced this issue Apr 11, 2020
@atodorov
api: Convert TestPlan.create() & TestPlan.update() to ModelForm
7018384 
Refs #1384, #171
atodorov added a commit that referenced this issue Apr 12, 2020
@atodorov
Convert NewPlanForm into ModelForm. Refs #1384, #171
e17ab72
atodorov added a commit that referenced this issue Apr 12, 2020
@atodorov
api: Convert TestPlan.create() & TestPlan.update() to ModelForm
3f562cc 
Refs #1384, #171
atodorov added a commit that referenced this issue Apr 13, 2020
@atodorov
Remove unused clean_request(). Refs #171
77acfd4
atodorov added a commit that referenced this issue Apr 22, 2020
@atodorov
Remove unused clean_request(). Refs #171
2afa867
asankov pushed a commit to asankov/Kiwi that referenced this issue Apr 22, 2020
@atodorov @asankov
Remove unused clean_request(). Refs kiwitcms#171
92ede66
atodorov added a commit that referenced this issue May 12, 2020
@atodorov
Remove unused clean_request(). Refs #171
f9858ad
atodorov added a commit that referenced this issue May 17, 2020
@atodorov
Remove unused clean_request(). Refs #171
d61f89e
atodorov added a commit that referenced this issue Aug 23, 2020
@atodorov
Remove unused clean_request(). Refs #171
2cbdf92
atodorov added a commit that referenced this issue Sep 9, 2020
@atodorov
Remove unused clean_request(). Refs #171
79fec57
atodorov added a commit that referenced this issue Sep 19, 2020
@atodorov
Remove unused clean_request(). Refs #171
1189722
atodorov added a commit that referenced this issue Sep 22, 2020
@atodorov
Remove unused clean_request(). Refs #171
54279cc
atodorov added a commit that referenced this issue Oct 2, 2020
@atodorov
Remove unused clean_request(). Refs #171
2fbb07d
atodorov added a commit that referenced this issue Oct 12, 2020
@atodorov
Remove unused clean_request(). Refs #171
8d84541
atodorov added a commit that referenced this issue Oct 12, 2020
@atodorov
Remove unused clean_request(). Refs #171
cab7c30
atodorov added a commit that referenced this issue Oct 14, 2020
@atodorov
Remove unused clean_request(). Refs #171
2d0756f
atodorov added a commit that referenced this issue Oct 18, 2020
@atodorov
Remove unused clean_request(). Refs #171
c2c358a
atodorov added a commit that referenced this issue Nov 8, 2020
@atodorov
Remove unused clean_request(). Refs #171
c45ce92
atodorov added a commit that referenced this issue Nov 20, 2020
@atodorov
Remove unused clean_request(). Refs #171
dcef2c3
atodorov added a commit that referenced this issue Dec 1, 2020
@atodorov
Remove unused clean_request(). Refs #171
3514f2b
atodorov added a commit that referenced this issue Dec 1, 2020
@atodorov
Remove unused clean_request(). Refs #171
279559f
asankov pushed a commit to asankov/Kiwi that referenced this issue Dec 2, 2020
@atodorov @asankov
Remove unused clean_request(). Refs kiwitcms#171
c95729f
atodorov added a commit that referenced this issue Mar 6, 2021
@atodorov
DB: Remove unused TestRun.product_version field
c7441a5 
- API method TestRun.filter() will return fields:
  - `plan__product_version`
  - `plan__product_version__value`

- Tests and forms have been adjusted

- Resolves the last pylint warning. Closes #171
@atodorov atodorov mentioned this issue Mar 6, 2021
Merged
atodorov added a commit that referenced this issue Mar 6, 2021
@atodorov
DB: Remove unused TestRun.product_version field
e71c4a3 
- API method TestRun.filter() will return fields:
  - `plan__product_version`
  - `plan__product_version__value`

- Tests and forms have been adjusted

- Resolves the last pylint warning. Closes #171
APiligrim referenced this issue in MLH-Fellowship/Kiwi Mar 25, 2021
@atodorov @APiligrim
DB: Remove unused TestRun.product_version field
827b5ff 
- API method TestRun.filter() will return fields:
  - `plan__product_version`
  - `plan__product_version__value`

- Tests and forms have been adjusted

- Resolves the last pylint warning. Closes #171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DB: Remove unused TestRun.product_version field kiwitcms/Kiwi
3 participants
@atodorov @asankov @ivo0126