-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to Test Execution #1842
Add link to Test Execution #1842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modal needs visual adjustments.
dc85236
to
e71ce80
Compare
I still need to fix the alignment of the switch, everything else should be good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When adding a hyperlink with Is defect = Yes I get an error on the console.
TypeError: link is undefined
- needs testing & fixing.
Also there's no visual feedback that the action was completed. On the refactor_testplan_ui branch there's a small animation effect for each row for these bulk actions that should help. It should probably become a shared function.
86c3605
to
c28e3d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebase and leave only the last commits
to be used in the modal that creates hyperlink for out-of-the-box validation
For each TestExecution in TestRun page. Use LinkReference form for validation.
- mark text for translation - remove 'update bug tracker' dropdown - use 'template' instead of html in js - `btn-danger`, not `btn-default`
30c7c0f
to
4c4385c
Compare
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Label & input alignment still not aligned very well:
See this comment #1842 (comment)
Still missing animation for visual feedback that something has changed, see #1842 (review)
@atodorov both should be resolved now |
No description provided.