Add link to Test Execution #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
atodorov
requested changes
Aug 11, 2020
asankov
force-pushed
the
testrun-executions-addlink-modal
branch
from
dc85236
to
e71ce80
Compare
asankov
commented
Aug 19, 2020
|
I still need to fix the alignment of the switch, everything else should be good |
atodorov
requested changes
Aug 20, 2020
There was a problem hiding this comment.
When adding a hyperlink with Is defect = Yes I get an error on the console.
TypeError: link is undefined - needs testing & fixing.
Also there's no visual feedback that the action was completed. On the refactor_testplan_ui branch there's a small animation effect for each row for these bulk actions that should help. It should probably become a shared function.
atodorov
force-pushed
the
refactor_testrun_ui
branch
from
86c3605
to
c28e3d6
Compare
atodorov
requested changes
Aug 23, 2020
to be used in the modal that creates hyperlink for out-of-the-box validation
For each TestExecution in TestRun page. Use LinkReference form for validation.
- mark text for translation - remove 'update bug tracker' dropdown - use 'template' instead of html in js - `btn-danger`, not `btn-default`
asankov
force-pushed
the
testrun-executions-addlink-modal
branch
from
30c7c0f
to
4c4385c
Compare
|
rebased |
atodorov
requested changes
Aug 24, 2020
There was a problem hiding this comment.
Label & input alignment still not aligned very well:
See this comment #1842 (comment)
Still missing animation for visual feedback that something has changed, see #1842 (review)
|
@atodorov both should be resolved now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.