Testrun executions one click bug report #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
refactor_testrun_ui
branch
from
86c3605
to
c28e3d6
Compare
atodorov
requested changes
Aug 23, 2020
|
no need to rebase now. will do it once #1842 is merged |
asankov
force-pushed
the
testrun-executions-one-click-bug
branch
from
00e05e3
to
570c56e
Compare
asankov
changed the title
atodorov
requested changes
Aug 28, 2020
via one-click to new Test Run page
asankov
force-pushed
the
testrun-executions-one-click-bug
branch
from
570c56e
to
0607c8d
Compare
atodorov
reviewed
Aug 29, 2020
| // this handler must be here, because if we bind it when the page is loaded. | ||
| // we have no way of knowing for what execution ID the form is submitted for. | ||
| $('.one-click-bug-report-form').submit(() => { | ||
| const trackerId = $('.one-click-bug-report-form #id-issue-tracker').val() |
There was a problem hiding this comment.
this selector is overqualified. If you have an ID that's enough to select.
atodorov
approved these changes
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #1842 because a lot of stuff are reused
tested with local Kiwi TCMS tracker