Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates in the language list #45

Closed
kelson42 opened this issue Dec 10, 2016 · 6 comments
Closed

Duplicates in the language list #45

kelson42 opened this issue Dec 10, 2016 · 6 comments
Assignees
Labels

Comments

@kelson42
Copy link
Contributor

I have a lots of duplicates in the content manager language list. For example "Low German", "Lower Sorbian", "Ligurian", etc... I dozen of languages have duplicates.

@automactic
Copy link
Member

What do you mean? Do you see the exact duplicate? For example two "German". They could be different dialect of the same lang family

@kelson42
Copy link
Contributor Author

Yes I see duplicates. We should find a solution to difference them (if they are not pointing to the same language).

@Popolechien
Copy link
Member

Got the exact same comment today in the OTRS feeback queue:
"Hello,
on my first iPod i have 36 books abailable for download, some of them twice. On my other
iPod there are 51 books abailable for download, some of them even three times.
What's wrong?
Best regards"

@automactic
Copy link
Member

automactic commented Jan 31, 2017

@Popolechien, I can't think of why this could happen. App will always check if book with an id or a language with a code exist before inserting a new one. If the user is using an earlier version or upgrade from an earlier version, it might be possible that the app allows 2 background threads to download library.xml and process at the same time.

In upcoming version 1.8, the underlying SQLite store will have unique constraint on the id field of book and on code field of language. Duplicates will be discarded during the upgrade process.

An extra note regarding languages: all language code will be converted to canonical form, e.g. "eng" -> "en"

Oh and nice dog!!

@Popolechien
Copy link
Member

Ok, thanks for the clarification!

@automactic
Copy link
Member

Closing this, since there is no way to reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants