Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site just displays the loading spinner #4

Closed
rashiq opened this issue Jul 19, 2014 · 4 comments
Closed

Site just displays the loading spinner #4

rashiq opened this issue Jul 19, 2014 · 4 comments
Assignees
Labels

Comments

@rashiq
Copy link
Contributor

rashiq commented Jul 19, 2014

The commit e993ffcb294e7f2cbe02a55305e7f443f8301d01 by @kelson42 broke the site. It's only displaying the loading-spinner now.

bildschirmfoto 2014-07-19 um 22 05 17

Reproduce it by exporting the site:

./dump-gutenberg.py --export -l en

I have tested this on Chrome, Firefox and Safari.

@kelson42
Copy link
Contributor

Just change the script.src assignement in tools.js for testing without zim.

On 07/19/2014 10:06 PM, Rashiq Ahmad wrote:

The commit e993ffc
e993ffc
by @kelson42 https://github.com/kelson42 broke the site. It's only
displaying the loading-spinner now.

bildschirmfoto 2014-07-19 um 22 05 17
https://cloud.githubusercontent.com/assets/1624385/3635610/084b447a-0f80-11e4-99bf-d70687bd6f78.png


Reply to this email directly or view it on GitHub
#4.

@rashiq
Copy link
Contributor Author

rashiq commented Jul 19, 2014

works 👍

@rashiq rashiq closed this as completed Jul 19, 2014
@Seb35
Copy link
Contributor

Seb35 commented Jul 21, 2014

This should better handled with some test in JS, but I don’t know how to test if we are in Kiwix or in a browser.

@Seb35 Seb35 reopened this Jul 21, 2014
@kelson42
Copy link
Contributor

If you have a test case, this is welcomed ;) To my opinion, there is no clean way to test this in JS. A solution would be to make this switch/choice in Python, just before and only for the zimification of the content (templatify tools.js?).

@rgaudin rgaudin closed this as completed in 6a5370a Apr 7, 2017
rgaudin pushed a commit that referenced this issue May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants