Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly work around need to add final slash to root URLs when checking a link clicked by user #1231

Open
Jaifroid opened this issue Mar 16, 2024 · 0 comments
Assignees
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix upstream Issues that need to be dealt with at scraper level or some other repo zimit Code relating to the support of Zimit-style archives

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Mar 16, 2024

For context see openzim/warc2zim#210 (comment). We currently handle the case of removing a final slash, but depending on the outcome of that issue, we might also need to handle the opposite case.

Note that if this ends up being handled at warc2zim2 level, we might be able to remove the current workaround.

EDIT: This is for zimit2, but the code is currently generalized and is also used for zimit1.

@Jaifroid Jaifroid added upstream Issues that need to be dealt with at scraper level or some other repo bug-non-critical For bugs that it would be nice to fix rather than critical to fix zimit Code relating to the support of Zimit-style archives labels Mar 16, 2024
@Jaifroid Jaifroid self-assigned this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix upstream Issues that need to be dealt with at scraper level or some other repo zimit Code relating to the support of Zimit-style archives
Projects
None yet
Development

No branches or pull requests

1 participant