-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kiwix-serve] make the topbar customizable. #17
Comments
@mgautierfr We have meanwhile rewritten the topbar in a more friendly manner. I wonder a bit how such a feature would/could looks like, considering that it should probably deal with HTML/CSS/JS/pictures. |
@mgautierfr I get once kiwix/libkiwix#394 is implemented, we could just use a similar approach like kiwix/libkiwix#571 ?! |
Moving this task to @veloman-yunkan, this is IMO now straigt and trivial to implement this option, once kiwix/libkiwix#716 will be merged. |
We should not forget to update the |
At BSF, we need to change how the topbar is displayed. (Css but also displayed buttons).
I've got a working version, but it is based on some kind of hidden feature of the last kiwix-serve/kiwix-lib allowing to change the embedded resources at runtime with env var.
It's working but it is not perfect and error prone. (ideascube/ideascube#590 and ideascube/ansiblecube#43)
On top of it, we will end to rewrite a part of the topbar to make it more mobile friendly. (kiwix/kiwix-xulrunner#336)
It could be a good opportunity to think about how we add the topbar.
The text was updated successfully, but these errors were encountered: