Fix kiwix-serve fulltext result page template wording (english)

[tim-moody]

No result were found for XXX should read

No results were found for XXX

[kelson42]

@tim-moody Can you please make a detailed bug report with all the details needed to reproduce the problem?

[tim-moody]

easy. enter any search argument that returns no results and look at the message.

[kelson42]

Which ZIM file?
What is the kiwix-serve command you have started?
Which version of kiwix-serve?
What is the string you exactly enter?
What do you get exactly?
What do you expect and why?

[tim-moody]

1. download and untar http://download.kiwix.org/nightly/2017-04-30/kiwix-tools_armhf_2017-04-30.tar.gz
2. run /opt/schoolserver/kiwix/bin/kiwix-serve --port 3000 /library/zims/content/wikipedia_en_medicine_2017-04.zim
3. navigate browser to :3000
4. open medical wiki by clicking appropriately
5. enter XXXXXXX in search field
6. click on containing 'XXXXXXX'
   7A. screen displays No result were found for XXXXXXX
   7B. screen should display No results were found for XXXXXXX
   The reason I expect this is because English has agreement between subject and verb with respect to number and the plural is idiomatically correct.

[tim-moody]

I see that this bug existed in prior versions

[kelson42]

This is a bit less trivial as it looks like because of 2d29753271123d9dc670d96306e192e11c860853. The point is that is looks like we can not change it easily now, @rgaudin you confirm? I'm not sure what would be the best approach. now. @mgautierfr Any ideas?

[rgaudin]

@kelson42, can you add a link to that commit?

Last time I looked at that code (2years?), it was an English-only template results.tmpl which could be easily fixed but maybe search (and its results) have moved to kiwix-lib now?

[kelson42]

@rgaudin It's still english-only, but how to generate the results.ct2 file?

[mgautierfr]

It seems that the ct2 file is generated by ctpp2c binary coming from ctpp2 dependency.

The results.ct2 is stored in the kiwix-lib repository (it's the searcher from kiwix-lib who use it).
We should store the results.tmpl in the repository and make the build system automatically generate the results.ct2.

[tim-moody]

this remains in nightly 5-29

[kelson42]

We need to fix this first kiwix/libkiwix#50

[kelson42]

Fixed with kiwix/libkiwix@b6a58d1