-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to host books with FileDescriptor on Server
#1015
Comments
Support in Now I am not sure that API-wise it makes sense to pretend that we support opening ZIM files via file-descriptor. Instead we better support only file-paths and let the clients convert fds to paths on their own. However, opening ZIMs via fds is different in that it also requires supplying offset and data size values.
I think that we should unify those two cases into "a collection of (file-path, offset, data-chunk-size) triplets", introduce in @kelson42 @mgautierfr What do you think? |
@veloman-yunkan @mgautierfr To me this ticket is basically a duplicate of openzim/libzim#852 and I would like to close ot at such. |
I think this issues around fd are a bit different, as they may have different root cause:
However, (if this issue is not already fixed) we should tackle this thinking globally about an api to allow us to read data from source for which we don't have a path or we cannot directly reopen it. So no need to have several issues about that, I will close this issue in favor of openzim/libzim#852. |
We introduced the hosting books feature for
KiwixCustomApps
a few days back, and now we are usingFileDescriptor
to read the zim files from the asset folder in kiwix/kiwix-android#3516. While refactoring the server functionality to use theFileDescriptor
to host the zim file onServer
we have seen that the server is unable to host books withFileDescriptor
.I don't know if it is possible to host zim files with
FileDescriptor
, if possible how much time it will take to implement.I am creating this ticket for this bug to further conversation on this.
The text was updated successfully, but these errors were encountered: