Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't introduce taskbar for non-front articles #671

Closed
rgaudin opened this issue Jan 7, 2022 · 1 comment · Fixed by #716
Closed

Don't introduce taskbar for non-front articles #671

rgaudin opened this issue Jan 7, 2022 · 1 comment · Fixed by #716
Assignees
@veloman-yunkan
Labels
enhancement
Milestone
12.0.0

Comments

@rgaudin
Copy link
Member

rgaudin commented Jan 7, 2022

When creating a ZIM, HTML Items with FRONT_ARTICLE=false hints are considered non-front articles. As such, the taskbar should not be introduced for them.

I'm not sure about how it should be implemented as Hints are create-time only. I suppose it would rely on the index…

This should allow us to stop depending on text/html;raw=true mime types.
@kelson42 kelson42 added this to the 10.1.0 milestone Jan 7, 2022
@kelson42
Copy link
Collaborator

kelson42 commented Jan 7, 2022

Related to #394

@kelson42 kelson42 modified the milestones: 10.1.0, 10.2.0, 10.3.0 Mar 23, 2022
@kelson42 kelson42 modified the milestones: 10.2.0, 10.3.0 Apr 7, 2022
@kelson42 kelson42 modified the milestones: 10.2.0, 10.3.0 Apr 23, 2022
@kelson42 kelson42 mentioned this issue Jun 25, 2022
Merged
@kelson42 kelson42 modified the milestones: 12.1.0, 12.0.0 Jul 7, 2022
@rgaudin rgaudin mentioned this issue Jan 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veloman-yunkan veloman-yunkan

Labels
enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

Iframe-based content viewer kiwix/libkiwix
3 participants
@rgaudin @kelson42 @veloman-yunkan