Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included tags in free text catalog search #802

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

veloman-yunkan
Copy link
Collaborator

Fixes #599

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #802 (4cd52b0) into master (dd90ca1) will not change coverage.
The diff coverage is n/a.

❗ Current head 4cd52b0 differs from pull request most recent head 078c400. Consider uploading reports for the commit 078c400 to get more accurate results

@@           Coverage Diff           @@
##           master     #802   +/-   ##
=======================================
  Coverage   70.63%   70.63%           
=======================================
  Files          53       53           
  Lines        3708     3708           
  Branches     2061     2061           
=======================================
  Hits         2619     2619           
  Misses       1087     1087           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kelson42 kelson42 added this to Review in Better library Jul 30, 2022
@kelson42 kelson42 force-pushed the include_tags_in_free_text_library_search branch from 77cddb0 to afa357d Compare August 1, 2022 13:18
@kelson42 kelson42 force-pushed the include_tags_in_free_text_library_search branch from afa357d to 078c400 Compare August 3, 2022 14:14
@kelson42 kelson42 force-pushed the include_tags_in_free_text_library_search branch from 078c400 to cff143b Compare August 6, 2022 05:39
@kelson42
Copy link
Collaborator

kelson42 commented Aug 6, 2022

@mgautierfr Can we merge this?

Copy link
Member

@mgautierfr mgautierfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgautierfr mgautierfr merged commit d737db6 into master Aug 10, 2022
@mgautierfr mgautierfr deleted the include_tags_in_free_text_library_search branch August 10, 2022 14:43
@kelson42 kelson42 moved this from Review to Done in Better library Sep 24, 2022
mgautierfr added a commit that referenced this pull request Nov 30, 2022
* [API Break] Remove wrapper around libzim (@mgautierfr #789)
* Allow kiwix-serve to use custom resource files (@veloman-yunkan #779)
* Properly handle searchProtocolPrefix when rendering search result (@veloman-yunkan #823)
* Prevent search on multi language content (@veloman-yunkan #838)
* Use new `zim::Archive::getMediaCount` from libzim (@mgautierfr #836)
* Catalog:
 - Include tags in free text catalog search (@veloman-yunkan #802)
 - Illustration's url is based on book's uuid (@veloman-yunkan #804)
 - Cleanup of the opds-dumper (@veloman-yunkan #829)
 - Allow filtering of catalog content using multiple languages (@veloman-yunkan #841)
 - Make opds-dumper respect the namemapper (@mgautierfr #837)
* Server:
 - Correctly handle `\` in suggestion json generation (@veloman-yunkan #843)
 - Better http caching (@veloman-yunkan #833)
 - Make `/suggest` endpoint thread-safe (@veloman-yunkan #834)
 - Better redirection of main page (@veloman-yunkan #827)
 - Remove jquery (@mgautierfr @juuz0 #796)
 - Better Viewer of zim content :
   . Introduce `/content` endpoints (@veloman-yunkan #806)
   . Switch to iframe based content viewer (@veloman-yunkan #716)
 - Optimised design of the welcome page:
   . Alignement (@juuz0 @kelson42 #786)
   . Exit download modal on pressing escape key (@Juzz0 #800)
   . Add favicon for different devices (@Juzz0 #805)
   . Fix auto hidding of the toolbar (@veloman-yunkan #821)
   . Allow user to filter books by tags in the front page (@juuz0 #711)
* CI :
  - Trigger CI on pull_request (@kelson42 #791)
  - Drop Ubuntu Impish packaging (@legoktm #825)
  - Add Ubuntu Kinetic packaging (@legoktm #801)
* Testing:
  - Test ICULanguageInfo (@veloman-yunkan #795)
  - Introduce fake `test` language to test i18n (@veloman-yunkan #848)
* Fix documentation (@kelson42 #816)
* Udpate translation (#787 #839 #847)
@mgautierfr mgautierfr mentioned this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Integrate tags to free text library search
3 participants