Backslash handling in suggestions #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloman-yunkan
force-pushed
the
backslash_handling_in_suggestions
branch
from
0e3bcf9
to
e26e23f
Compare
|
CI fails because of the dependence of this PR on openzim/libzim#740 |
mgautierfr
approved these changes
Nov 16, 2022
mgautierfr
force-pushed
the
backslash_handling_in_suggestions
branch
from
e26e23f
to
dda632d
Compare
Codecov ReportBase: 70.87% // Head: 70.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 70.87% 70.98% +0.11%
==========================================
Files 53 53
Lines 3667 3681 +14
Branches 2035 2042 +7
==========================================
+ Hits 2599 2613 +14
Misses 1066 1066
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The new unit test fails because of a buggy mishandling of backslashes in suggestions. The fix is coming next.
veloman-yunkan
force-pushed
the
backslash_handling_in_suggestions
branch
from
dda632d
to
7743e73
Compare
|
Simply rebased after #839 was merged. |
|
We should fix the macos CI problem the same way it has been done yesterday on openzim/libzim. |
kelson42
force-pushed
the
backslash_handling_in_suggestions
branch
2 times, most recently
from
7e3d841
to
06c3eb7
Compare
|
CI OK now beside the packaging problen, so merging |
kelson42
force-pushed
the
backslash_handling_in_suggestions
branch
from
06c3eb7
to
d66cc62
Compare
mgautierfr
added a commit
that referenced
this pull request
Nov 30, 2022
* [API Break] Remove wrapper around libzim (@mgautierfr #789) * Allow kiwix-serve to use custom resource files (@veloman-yunkan #779) * Properly handle searchProtocolPrefix when rendering search result (@veloman-yunkan #823) * Prevent search on multi language content (@veloman-yunkan #838) * Use new `zim::Archive::getMediaCount` from libzim (@mgautierfr #836) * Catalog: - Include tags in free text catalog search (@veloman-yunkan #802) - Illustration's url is based on book's uuid (@veloman-yunkan #804) - Cleanup of the opds-dumper (@veloman-yunkan #829) - Allow filtering of catalog content using multiple languages (@veloman-yunkan #841) - Make opds-dumper respect the namemapper (@mgautierfr #837) * Server: - Correctly handle `\` in suggestion json generation (@veloman-yunkan #843) - Better http caching (@veloman-yunkan #833) - Make `/suggest` endpoint thread-safe (@veloman-yunkan #834) - Better redirection of main page (@veloman-yunkan #827) - Remove jquery (@mgautierfr @juuz0 #796) - Better Viewer of zim content : . Introduce `/content` endpoints (@veloman-yunkan #806) . Switch to iframe based content viewer (@veloman-yunkan #716) - Optimised design of the welcome page: . Alignement (@juuz0 @kelson42 #786) . Exit download modal on pressing escape key (@Juzz0 #800) . Add favicon for different devices (@Juzz0 #805) . Fix auto hidding of the toolbar (@veloman-yunkan #821) . Allow user to filter books by tags in the front page (@juuz0 #711) * CI : - Trigger CI on pull_request (@kelson42 #791) - Drop Ubuntu Impish packaging (@legoktm #825) - Add Ubuntu Kinetic packaging (@legoktm #801) * Testing: - Test ICULanguageInfo (@veloman-yunkan #795) - Introduce fake `test` language to test i18n (@veloman-yunkan #848) * Fix documentation (@kelson42 #816) * Udpate translation (#787 #839 #847)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #842.
Depends on openzim/libzim#740.
The fix of #842 is quite small (as illustrated by the commit titled "Fixed handling of backslashes in suggestions") however properly testing it was problematic for the lack of necessary data in the available test ZIM files. The solution to that challenge was to extract the functionality into a separate utility that could be unit-tested. That's what is mostly done in this PR.