Catalog filtering by multiple languages #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 71.16% // Head: 71.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #841 +/- ##
==========================================
+ Coverage 71.16% 71.20% +0.03%
==========================================
Files 53 53
Lines 3711 3716 +5
Branches 2060 2062 +2
==========================================
+ Hits 2641 2646 +5
Misses 1068 1068
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
It turned out |
From now on, the `lang` parameter of the /catalog/search, /catalog/v2/entries, and /catalog/v2/partial_entries endpoints is interpreted as a comma-separated list of languages.
mgautierfr
force-pushed
the
catalog_filtering_by_multiple_languages
branch
from
2fce69c
to
7765769
Compare
|
@veloman-yunkan Thank your for this PR. Please don't forget to update the wiki (again) |
|
Done |
mgautierfr
added a commit
that referenced
this pull request
Nov 30, 2022
* [API Break] Remove wrapper around libzim (@mgautierfr #789) * Allow kiwix-serve to use custom resource files (@veloman-yunkan #779) * Properly handle searchProtocolPrefix when rendering search result (@veloman-yunkan #823) * Prevent search on multi language content (@veloman-yunkan #838) * Use new `zim::Archive::getMediaCount` from libzim (@mgautierfr #836) * Catalog: - Include tags in free text catalog search (@veloman-yunkan #802) - Illustration's url is based on book's uuid (@veloman-yunkan #804) - Cleanup of the opds-dumper (@veloman-yunkan #829) - Allow filtering of catalog content using multiple languages (@veloman-yunkan #841) - Make opds-dumper respect the namemapper (@mgautierfr #837) * Server: - Correctly handle `\` in suggestion json generation (@veloman-yunkan #843) - Better http caching (@veloman-yunkan #833) - Make `/suggest` endpoint thread-safe (@veloman-yunkan #834) - Better redirection of main page (@veloman-yunkan #827) - Remove jquery (@mgautierfr @juuz0 #796) - Better Viewer of zim content : . Introduce `/content` endpoints (@veloman-yunkan #806) . Switch to iframe based content viewer (@veloman-yunkan #716) - Optimised design of the welcome page: . Alignement (@juuz0 @kelson42 #786) . Exit download modal on pressing escape key (@Juzz0 #800) . Add favicon for different devices (@Juzz0 #805) . Fix auto hidding of the toolbar (@veloman-yunkan #821) . Allow user to filter books by tags in the front page (@juuz0 #711) * CI : - Trigger CI on pull_request (@kelson42 #791) - Drop Ubuntu Impish packaging (@legoktm #825) - Add Ubuntu Kinetic packaging (@legoktm #801) * Testing: - Test ICULanguageInfo (@veloman-yunkan #795) - Introduce fake `test` language to test i18n (@veloman-yunkan #848) * Fix documentation (@kelson42 #816) * Udpate translation (#787 #839 #847)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kiwix/kiwix-tools#358
The requested functionality is implemented in a slightly different way. The OPDS query was assumed to be a conjunction (AND) of the filtering criteria. Handling multiple
langparameters as a disjunction (OR) may lead to confusion. Instead the set of desired languages must be specified as a comma-separated list via a singlelangparameter (similar to how thetagparameter works).The enhancement applies to 3 endpoints:
/catalog/search/catalog/v2/entries/catalog/v2/partial_entriesNote, however, that corresponding unit-tests have been provided only for the first two of them. Filtering of
/catalog/v2/partial_entrieswas not tested (when that endpoint was introduced) because it shares the same code with/catalog/v2/entries.