Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atlas Scientific EC sensor setup bug #1065

Closed
treesnsnacks opened this issue Aug 2, 2021 · 9 comments
Closed

Atlas Scientific EC sensor setup bug #1065

treesnsnacks opened this issue Aug 2, 2021 · 9 comments

Comments

@treesnsnacks
Copy link

Describe the problem/bug

Atlas scientific EC sensor wont report a value on its default settings and doesn't support all the measurements the sensor can report.

Versions:

  • Mycodo Version: 8.11.0
  • Raspberry Pi Version: 4B 4gb
  • Raspbian OS Version: 5.10.17

Reproducibility

Please list specific setup details that are involved and the steps to reproduce the behavior:

  1. Connect EC sensor and verified it shows up on i2c device list
  2. Attempt to get reading and show no value

Expected behavior

Expected conductivity, total dissolved solids, salinity, and specific gravity values to be reported as that's what the data sheet online shows the circuit reports. Need to update Atlas Scientific EC input to support multiple values and maybe a note somewhere about the difference in default settings between newer and older board which prevents using older boards with their default settings.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

After accidently getting it to report on the humidity sensor input that supports multiple values it became clear that the EC input was only expecting one value which was why it wouldn't work. After reading the datasheet more I saw that newer boards only report EC by default until you enable the other values so I disabled the all the values except EC on my board and was able to get it to work under the proper atlas scientific EC input but only showing the EC value.

@kizniche
Copy link
Owner

kizniche commented Aug 2, 2021

Thanks for the bug report. What firmware version is your sensor? This can be found in the daemon log after activating the input. I can add an additional Input for newer firmwares that include the additional values.

@treesnsnacks
Copy link
Author

Its 2.15 but from my understanding they all support the same values just any firmware above 2.10 by DEFAULT only shows EC and you need to manually turn on the rest, I must have switched the settings in the past as I have a newer firmware that should have only reported EC and I messed with the sensor a bit before finding your software. So not sure if necessary to make a new input maybe just update the old one to have the option to turn off certain values like you have in the humidity sensor.

@kizniche
Copy link
Owner

kizniche commented Aug 2, 2021

The new Input will select the values to return upon activation (for example, like the Atlas RGB sensor), based on what measurements the user selects to record. The original input cannot be just modified to include new measurements, as there are a number of users already using this input. Additionally, there cannot be the option to select measurements that don't exist for the old sensor firmware. And since Mycodo cannot know the firmware version prior to activation, there's no other way for Mycodo to render the appropriate options to the user unless there are two different Inputs that the user can select from.

kizniche added a commit that referenced this issue Aug 7, 2021
…H sensors (#1064), add TDS, Salinity, and Specific Gravity measurements for Atlas Scientific EC sensor (#1065), add temperature compensation to Atlas Dissolved Oxygen sensor
@kizniche
Copy link
Owner

kizniche commented Aug 7, 2021

I just committed changes that should fix this. If you upgrade to master to test, test with a single measurement enabled as well as multiple measurements, as well as in different combinations, and let me know if it works as expected. Thanks.

@kizniche
Copy link
Owner

kizniche commented Aug 7, 2021

You'll need to delete your current Input and add a new Input to see the new measurement selections.

@treesnsnacks
Copy link
Author

Tried it out today and its still not working. EC alone still works but once u add other measurements none report anything. It looks like it is sending the command and configuring the sensor to output the right measurements, every time i changed settings and reactivated i was checking the values on atlas's sample code and they would show the new measurements. But on mycodo live view the measurements all show 0 unless i go back to only using EC.

@kizniche
Copy link
Owner

Can you provide the debug log line that shows what's returned from the sensor when all measurements are enabled?

@kizniche
Copy link
Owner

I just committed a change to the Input that adds a few more debug logging lines, if you want to update to master and run the Input with Log Level: Debug enabled to see some more information about which measurements get enabled and the return values.

@treesnsnacks
Copy link
Author

Updated and seems to be working fine tried every output individually then in groups and they all report their values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants