Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cleanup README; add link to chemrxiv #85

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Conversation

byooooo
Copy link
Collaborator

@byooooo byooooo commented Nov 10, 2020

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Actions (for code changes)

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Nov 10, 2020

Codecov Report

Merging #85 (7c66c46) into master (be43252) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          12       12           
  Lines         775      775           
=======================================
  Hits          749      749           
  Misses         26       26           
Flag Coverage Δ
unittests 96.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be43252...7c66c46. Read the comment docs.

@kjappelbaum
Copy link
Owner

kjappelbaum commented Nov 10, 2020

😆 we had #84

@kjappelbaum
Copy link
Owner

I will merge yours but we should also change it in the Sphinx

@kjappelbaum kjappelbaum linked an issue Nov 10, 2020 that may be closed by this pull request
2 tasks
@byooooo
Copy link
Collaborator Author

byooooo commented Nov 10, 2020

haha oops! yea sorry. just saw your other PR!

Copy link
Owner

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only thing that probably should be fixed is the "cann" -> "can". Thanks 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@byooooo byooooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include corrections before merge

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@byooooo byooooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

committed corrections to PR

Copy link
Owner

@kjappelbaum kjappelbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks 👍

@kjappelbaum kjappelbaum merged commit 7c57043 into master Nov 10, 2020
@kjappelbaum kjappelbaum deleted the byooooo-patch-1 branch November 11, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update citation in docs and readme
3 participants