Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: pandas is changing _propogate_attributes #36

Closed
jreback opened this issue Oct 13, 2013 · 3 comments
Closed

API: pandas is changing _propogate_attributes #36

jreback opened this issue Oct 13, 2013 · 3 comments

Comments

@jreback
Copy link

jreback commented Oct 13, 2013

see here: pandas-dev/pandas#5205

now going to be called __finalize__, and data is now _metadata.
and going to called on pretty much everything before returning to the user.

I am thinking about allowing this:

def __finalize__(self, other, method=None, **kwargs):
....

so that in theory a sub-class (as you guys have done), could dispatch on the method (if you need/want).

does this help?

@kjordahl
Copy link
Member

@jreback Thanks for the heads-up. That sounds useful, and a bit more like an official API; a lot like numpy's __array_finalize__, in fact.

@jreback
Copy link
Author

jreback commented Oct 15, 2013

yep thats where it is modeled from

should be merged in shortly

@kjordahl
Copy link
Member

kjordahl commented Nov 2, 2013

Closing, addressed in #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants