Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV policy #673

Closed
daxpedda opened this issue Jan 19, 2023 · 4 comments · Fixed by #811
Closed

MSRV policy #673

daxpedda opened this issue Jan 19, 2023 · 4 comments · Fixed by #811

Comments

@daxpedda
Copy link

Considering #581 and #671 it might be useful to introduce an official MSRV policy.

@gwenn
Copy link
Collaborator

gwenn commented Jan 19, 2023

I would prefer not to have a MSRV.
Allow any incompatibility in major releases.
But, make sure that minor releases don't break X ? X = stable Rust version used by previous release ?
Because it is easier to follow only stable Rust releases.
See rusqlite/rusqlite#566

@daxpedda
Copy link
Author

That's a common MSRV policy.
E.g. https://github.com/RustCrypto/traits/tree/master/elliptic-curve#minimum-supported-rust-version.

Sounds good to me.

@gwenn
Copy link
Collaborator

gwenn commented Jan 19, 2023

Even minor releases can change MSRV ?
But still, you need to check patch releases...

@daxpedda
Copy link
Author

I'm a bit confused, do you want to keep the MSRV between patch releases or minor releases?

But yeah, you are not gonna be able to enforce it without setting up checks in CI probably.

In any case, any MSRV policy is better then none, even if you don't want to follow any MSRV at all.

@gwenn gwenn mentioned this issue Oct 7, 2024
@gwenn gwenn closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants