Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy completion with nucleo? #723

Closed
jaredramirez opened this issue Aug 18, 2023 · 1 comment
Closed

Fuzzy completion with nucleo? #723

jaredramirez opened this issue Aug 18, 2023 · 1 comment

Comments

@jaredramirez
Copy link

jaredramirez commented Aug 18, 2023

Rustyline currently uses skim to support fuzzy completion. This is really great, but unfortunately skim doesn't work on windows at the moment. (More details here: #326).

There's a new implementation of a fuzzy finder in Rust, called nucleo written by the folks from helix. This implemention is really new, but when it becomes more stable, it'd could be worth using in rustyline instead of skim. The main advantages would be:

  1. Windows folks could get fuzzy completion
  2. Other folks that use rustyline who are concerned about 1 can get fuzzy completion

I'm a user of Nushell (which uses rustyline) and would love to get fuzzy completion there, but it's currently blocked by skim not supporting windows (nushell/nushell#1275). So that's my motivation for this!

Due to nucleo's new-ness, there's no action to take right now, but I figured I'd open this ticket to put it on y'alls radar for whenever nucleo is stable!

@jaredramirez jaredramirez changed the title Fuzzy completion with Nucleo Fuzzy completion with Nucleo? Aug 18, 2023
@jaredramirez jaredramirez changed the title Fuzzy completion with Nucleo? Fuzzy completion with nucleo? Aug 18, 2023
@gwenn
Copy link
Collaborator

gwenn commented Aug 19, 2023

nushell uses reedline now (and not anymore rustyline).
Currently with rustyline you cannot customize how candidates are retrieved / displayed / selected.
If possible, I would prefer that rustyline exposes an API which let users implement their own completion interactive loop with nucleo or skim or ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants