-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement CharRefTokenizer #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkebo
force-pushed
the
named-char-ref
branch
from
November 26, 2023 03:05
618f8c4
to
9ddfa93
Compare
kkebo
force-pushed
the
named-char-ref
branch
from
February 13, 2024 15:45
813ba8b
to
6a0e367
Compare
kkebo
force-pushed
the
named-char-ref
branch
3 times, most recently
from
April 1, 2024 16:53
7523d00
to
acabf9f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kkebo
commented
Apr 3, 2024
Code Metrics Report
Details | | main (e55b299) | #39 (3a31200) | +/- |
|-----------|----------------|---------------|-------|
- | Coverage | 88.9% | 88.7% | -0.1% |
| Files | 7 | 8 | +1 |
| Lines | 1202 | 1258 | +56 |
+ | Covered | 1068 | 1116 | +48 | Code coverage of files in pull request scope (88.6% → 88.4%)
Reported by octocov |
kkebo
commented
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've implemented
CharRefTokenizer
.Benchmark Results