Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add DivMod hint #125

Closed
Tracked by #90
zmalatrax opened this issue Aug 6, 2024 · 2 comments · Fixed by #127
Closed
Tracked by #90

feat: add DivMod hint #125

zmalatrax opened this issue Aug 6, 2024 · 2 comments · Fixed by #127
Assignees
@coxmars
Labels
good first issue Good for newcomers

Comments

@zmalatrax
Copy link
Collaborator

Estimated time: 0.5d
Lifespan: 1d

  • Implement the DivMod hint.
  • Add unit tests, testing the parsing and the logic of the hint.
  • Add a Cairo program using the hint, used as an integration test .

How-to implement a hint on the Cairo VM TS available here

Rust implementation reference
@zmalatrax zmalatrax added the good first issue Good for newcomers label Aug 6, 2024
@zmalatrax zmalatrax mentioned this issue Aug 6, 2024
Open
@coxmars
Copy link
Contributor

coxmars commented Aug 6, 2024 •
edited
Loading

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi @zmalatrax, I'm a software developer with 2+ years of experience with Java, C#, Dart and others technologies and I'm member of Dojo Coding community here in CR and I have made contributions in Cairo VM Go, some days ago I implemented a hint there.

How I plan on tackling this issue

This will be my approach:

  1. Review Documentation and References: Understand the hint requirements and analyze existing implementations.
  2. Plan and Design the Implementation: Reference Rust and Cairo implementations.
  3. Implement the Hint in Cairo VM TS: Write the hint code following project guidelines.
  4. Add Unit Tests: Create unit tests to validate the hint implementation.
  5. Create Integration Tests: Develop integration tests to verify functionality within the system.
  6. Run Tests and Verify Implementation: Execute all tests to ensure correctness.
  7. Submit PR: Submit my pull request with a clear description and request feedback.

Thanks.

@zmalatrax
Copy link
Collaborator Author

Sure, assigned

@zmalatrax zmalatrax linked a pull request Aug 7, 2024 that will close this issue
feat: Add div mod hint #127
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coxmars coxmars

Labels
good first issue Good for newcomers
Projects
Cairo VM ts
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add div mod hint coxmars/cairo-vm-ts
2 participants
@zmalatrax @coxmars